Display search results in a tab instead of the side bar #23931

rfgamaral · 2017-04-05T11:46:44Z

I was talking to a colleague the other day and the only reason he's not using VS Code is because of how the search is implemented in VS Code and I have to agree with his opinion.

Both Sublime Text (which I'm used to) and Atom (the editor my colleague is using) feature a search tab. A search tab displays the results much more clearly given that there's much more space available to display them. Instead, VS Code displays them in a "small" side bar.

Yes, we can resize back and forth the side bar, but that's a bit annoying. It would be nice to have the search results displayed in a new tab similar to Sublime Text and Atom.

d-akara · 2017-04-06T00:32:36Z

I prefer the functionality of VS Code over sublimes implementation. I don't use sublime much, so maybe this is configurable; however, these are the limitations.

I can't simply cursor down over each match and have the file opened as I cursor down
It is harder to see just all the matches due to so much extra formatting and context around the matches
I often want to hide the side panel, but then go back to the last results again. Not sure how smoothly that will work from another document.

A wider display however could be useful. For example displaying in bottom panel instead of side panel.
Also, ability to capture the text of results would certainly be useful. #17920

roblourens · 2017-04-06T01:03:58Z

I know this has had some discussion before but can't find the issue right now. I've been toying with the idea of a button to dump the results from the viewlet into a sublime-style editor view, which would solve a few problems at once. Not sure how great that experience would be.

d-akara · 2017-04-06T01:32:25Z

@roblourens I can imagine lots of people have different ideas of how the contents of the dump should look. Would it be difficult to provide an API so that we could write extensions to do something with the results?

rfgamaral · 2017-04-06T11:41:01Z

Those are all valid points @dakaraphi :)

My only reasoning for this was the wider display to show the results. Currently it's cumbersome to go through the results (especially when there are many of them) because the sidebar, as a component, is narrow by default.

d-akara · 2017-04-06T12:37:46Z

@rfgamaral Thanks for clarifying. In this case, you might be interested following this item #2806

FezVrasta · 2017-05-22T10:44:33Z

I would love to have the search results shown on the bottom tabs where there's also "terminal" "output" and so on.

is it possible?

maxekman · 2017-05-23T13:31:46Z

IMO, all three options would be nice to have; in the sidebar, as a tab/buffer or in the console area.

bhat-ganesh · 2017-06-27T17:58:50Z

Is this feature supported yet?

leocaseiro · 2017-08-11T04:56:48Z

Isn't duplicated of #9435?

3zzy · 2017-08-23T03:14:03Z

+1 I really love the way Sublime displays the search results so you get a the overview without opening each file. I'll switch to VS Code once it has this.

shobhitg · 2017-09-28T15:55:24Z

I recently moved to VSCode. As a sublime user, while I feel at home, but Search UX is just not very good. I would love to see search results in wider bottom panel, which I can expand to full tab whenever I wish.

fatihacet · 2017-09-28T18:55:34Z

A huge 👍 to this issue. As a long time Sublime Text user, this is the deal breaker functionality. I often find myself resizing the search pane back and forth. Also lack of context in the VSCode search is another big thing. It makes very hard to find what you are looking for if you search something common in the codebase. Assume that you are new to the codebase, this is real pain in the ass.

Another fun fact is, Sublime or Atom version of displaying search results also allows you to search in the search results which is really handy.

Hope this feature lands in the VSCode sooner than later.

mikegreiling · 2017-09-28T19:22:29Z

likewise, I prefer to have more horizontal space to view search results 🙏

pxwee5 · 2017-10-03T02:58:52Z

Drop the search icon from the sidebar and just follow Atom's search UI.

shobhitg · 2017-10-09T19:23:47Z

Another fun fact is, Sublime or Atom version of displaying search results also allows you to search in the search results which is really handy.

This. Another thing that is very important.

I hope whenever the search's re-layout work done, this search within search results functionality is taken care of as well.

adamreisnz · 2017-10-27T21:51:33Z

I was talking to a colleague the other day and the only reason he's not using VS Code is because of how the search is implemented in VS Code

I'm so glad I'm not the only one. I'd really like to switch to vs code, as Atom is getting way too slow. But when I first tried to search in files and saw how the results were cramped inside the SIDE bar, I didn't know how fast to switch back after discovering that my only option was to make the sidebar wider manually, which also made it wider for the file explorer.

If vs code could copy a thing or two from Atom's UX it'd be a great editor, this is one of those things.

notrealdev · 2017-10-30T04:48:43Z

Display search results in a tab instead of the side bar please, like Sublime text

mshirlaw · 2017-10-30T18:33:16Z

This is the one reason I have yet to switch to vscode. I've tried to make the switch multiple times but I need to see more context about the search results without having to continuously resize the LHS panel. Would be very greatful if this was user configurable at some point in the future.

andrewdang17 · 2017-11-17T00:15:08Z

At the very least, the sidebar with search results should expand. I find myself resizing it to view the results, then resizing it back down.

shirazz · 2017-11-30T13:52:31Z

After using VSCode for a week, this is the only thing which is pulling me back to sublime. Really the search should be improved.

ghost · 2017-12-01T01:13:38Z

The VSCode search panel really need to be improved. It can't config the position and result displaying is too narrow.

aneilbaboo · 2018-01-06T01:33:27Z

Not being able to view search results and the explorer at the same time drives me crazy.

JacksonKearl · 2020-02-25T00:55:25Z

Extension for making changes in a search editor and applying those changes to the workspace at large. Helpful for multicursor-enhanced refactoring across many files:
https://marketplace.visualstudio.com/items?itemName=jakearl.search-editor-apply-changes

Edit: note this currently has some issues when working with large lines.

lucascosti · 2020-02-26T03:35:35Z

I'm really liking how this is coming along 👏

A few refinements I'd love to have:

Include the count of results in the openNewEditor top-of-the-screen interface, like there is in the bottom panel (e.g. 20 results in 15 files).
Remember the Show context setting. I have to re-set it each time a do a new search.

JacksonKearl · 2020-02-26T04:26:03Z

@lucascosti thanks for the feedback, please file separate issues for feature requests so the community can vote on them, as per our specification for handling feature requests.

dmi-dmi-dmi · 2020-03-02T01:52:53Z

Is there a way to open files from search editor not in the current editor group, but in the previously active one?

I want to be able to see list of search results + edit files at the same time.

JacksonKearl · 2020-03-02T04:31:41Z

@dmi-dmi-dmi does Open Definition to the Side work for your situation?

cafesanu · 2020-03-02T14:51:28Z

Hi! First, thank you for this feature! I now have totally abandoned Sublime Text now!

Second. For some reason Select All Occurrences of Find Match (via Show All Commands or the key shortcut) is not showing up or working in the search tab where all the results show. Any idea?

Thanks!

JacksonKearl · 2020-03-02T16:20:53Z

@cafesanu first, are you on Insiders or Stable? Search editors have been heavily polished this iteration.

In insiders, I see this:

Note that the action is not "Select All Occurrences of Find Match" but rather "selectAllSearchEditorMatches". This is because in the search editor you may still have a local in-editor find open that you want to select all occurrences of.

cafesanu · 2020-03-02T20:38:26Z

@JacksonKearl Nice. Yeah I am in Stable. I do see it in Insiders via the shortcut. Will use it!

Any way to see it in Show All Commands? Thanks!

cpascu · 2020-03-03T11:21:04Z

I can't seem to get the search to appear in a tab when right clicking a folder in the sidebar and selecting Find in Folder. I have enableSearchEditorPreview enabled. It seems to take the setting into account only when I start a new blank search.

I have enableSearchEditorPreview enabled, am I missing another setting somewhere?

JacksonKearl · 2020-03-03T16:32:04Z

@cpascu I have not yet made a setting to prefer the editor for the “find in folder” context menu action. If you submit a new issue I will look into it.

igolskyi · 2020-03-10T10:53:52Z

Can I set hotkeys on "search.searchEditor.doubleClickBehaviour": "goToLocation" instead of double click behavior?

JacksonKearl · 2020-03-10T18:28:01Z

@igolskyi I'm not sure what you mean. You can configure keybindings using the Keybindings Editor
https://code.visualstudio.com/docs/getstarted/keybindings

igolskyi · 2020-03-10T18:40:46Z

@JacksonKearl Yes, I want to configure keybinding for command "goToLocation" but I don't know how does it (command by double click) names.

JacksonKearl · 2020-03-10T21:13:55Z

@igolskyi the command run on double click will either be 'editor.action.goToDeclaration' or 'editor.action.openDeclarationToTheSide' depending on search.searchEditor.doubleClickBehaviour. Does that help? You can rebind those in the keybindings editor.

igolskyi · 2020-03-10T21:17:55Z

@JacksonKearl yes it's editor.action.goToDeclaration ) Thank you so much )

kolpav · 2020-03-11T08:24:23Z

I almost get this feature set up perfectly but I am unable to figure out how to always reuse the search tab I don't need new one for every search I make any ideas?

Btw this keybindings greatly improved my search experience. You open search editor with whatever shortcut you have it mapped to, start typing your search query press enter and it will focus search result window, press ctrl+n to go to next search result or press ctrl+p to go to previous one esc will focus search input again.

  {
    "key": "enter",             
    "command": "search.focus.nextInputBox",
    "when": "inSearchEditor && inputBoxFocus || inputBoxFocus && searchViewletVisible"
  },
  {
    "key": "ctrl+n",             
    "command": "search.action.focusNextSearchResult",
    "when": "inSearchEditor"
  },
  {
    "key": "ctrl+p",             
    "command": "search.action.focusPreviousSearchResult",
    "when": "inSearchEditor"
  }

andyd0 · 2020-03-11T12:22:24Z

Is there any way to default the original search to this? or a shortcut to bring it up the search editor? looks like we can only do it via the command pallet

yume-chan · 2020-03-11T16:08:46Z

@andyd0 You can assign a keyboard shortcut for the search.action.openNewEditor command.

You can also assign it to Ctrl + Shift + F, then remove the default shortcut on workbench.view.search command.

JacksonKearl · 2020-03-11T18:09:46Z

@kolpav

I am unable to figure out how to always reuse the search tab

No way to do this currently. If you open a feature request for this I will look into adding it.

press ctrl+n to go to next search result or press ctrl+p to go to previous one

F4 and Shift+F4 already do this for both search editors and the search viewlet, just btw.

press enter and it will focus search result window,

Neat.

dwelle · 2020-03-12T18:45:37Z

Can openLocationToSide not always consider only editor group to its right? Case: I want the search editor on the right side, and when I double click I want it to open the file in the editor group to its left (which already exists).

JacksonKearl · 2020-03-12T19:09:41Z

@dwelle It uses the existing editor.action.openDeclarationToTheSide command. You can open a separate feature request for that to consider other groups.

microsoft/vscode#23931

blakeprudhomme · 2020-03-19T20:50:36Z

@JacksonKearl Great work! Thank you!

PJUllrich · 2020-03-25T10:36:26Z

Is it only me or did this feature break the Replace All button of the global search?

My steps are same as before:

Open the Search Sidebar
Enter a Search Term
Click the little arrow left of the Search Term field
Enter a Replace Term
Hit "Enter" to search all occurrences and show a list of changes
Click the "Replace All" button on the right side of the Replace Term field
Nothing happens.

I must go through every file in the list of occurrences and apply the changes with the "Replace all" next to the file name. Do you have the same issue?

JacksonKearl · 2020-03-25T13:30:33Z

@PJUllrich yes; that’s tracked in #92443 and fixed in Insiders.

akbarsha03 · 2020-03-26T07:23:35Z

I got this new feature today with an update. But search results in a separate tab?. I mean, in a recent update from the vscode there was an option to shift the search result anywhere you like. I've moved mine right next to the terminal. This is quite handy than the search result in a separate tab. In fact, with the search results at the bottom, it's very much similar to the IntelliJ.

Check it out here:

https://code.visualstudio.com/updates/v1_42#_moving-views-from-the-sidebar-to-the-panel

chrmarti assigned roblourens Apr 5, 2017

chrmarti added search Search widget and operation issues feature-request Request for new features or functionality labels Apr 5, 2017

roblourens mentioned this issue Apr 11, 2017

Find in files using extenstion API #9049

Closed

roblourens mentioned this issue Jun 13, 2017

an option to display search results in output window #28594

Closed

roblourens mentioned this issue Jul 13, 2017

Add setting to show cross project find results in a tab like Sublime #30575

Closed

roblourens mentioned this issue Oct 27, 2017

Search and replace in multiple files is not usable with long lines #36660

Closed

nikopavlica mentioned this issue Jan 12, 2018

Suggestions for improving the "Find All References" window #31720

Closed

JacksonKearl mentioned this issue Feb 25, 2020

Test Search Editor #91331

Closed

3 tasks

Tyriar added the on-testplan label Feb 25, 2020

jaxspades mentioned this issue Mar 10, 2020

Tabs for integrated terminal #10546

Closed

knoxknox added a commit to knoxknox/dotfiles that referenced this issue Mar 16, 2020

Switch to new search in tab

1e0d089

microsoft/vscode#23931

github-actions bot locked and limited conversation to collaborators Apr 7, 2020

Display search results in a tab instead of the side bar #23931

Display search results in a tab instead of the side bar #23931

Comments

rfgamaral commented Apr 5, 2017

d-akara commented Apr 6, 2017 • edited Loading

roblourens commented Apr 6, 2017

d-akara commented Apr 6, 2017

rfgamaral commented Apr 6, 2017 • edited Loading

d-akara commented Apr 6, 2017

FezVrasta commented May 22, 2017 • edited Loading

maxekman commented May 23, 2017

bhat-ganesh commented Jun 27, 2017

leocaseiro commented Aug 11, 2017

3zzy commented Aug 23, 2017 • edited Loading

shobhitg commented Sep 28, 2017

fatihacet commented Sep 28, 2017 • edited Loading

mikegreiling commented Sep 28, 2017

pxwee5 commented Oct 3, 2017 • edited Loading

shobhitg commented Oct 9, 2017

adamreisnz commented Oct 27, 2017

notrealdev commented Oct 30, 2017

mshirlaw commented Oct 30, 2017

andrewdang17 commented Nov 17, 2017

shirazz commented Nov 30, 2017

ghost commented Dec 1, 2017

aneilbaboo commented Jan 6, 2018 • edited Loading

JacksonKearl commented Feb 25, 2020 • edited Loading

lucascosti commented Feb 26, 2020

JacksonKearl commented Feb 26, 2020

dmi-dmi-dmi commented Mar 2, 2020

JacksonKearl commented Mar 2, 2020

cafesanu commented Mar 2, 2020

JacksonKearl commented Mar 2, 2020

cafesanu commented Mar 2, 2020 • edited Loading

cpascu commented Mar 3, 2020

JacksonKearl commented Mar 3, 2020

igolskyi commented Mar 10, 2020

JacksonKearl commented Mar 10, 2020

igolskyi commented Mar 10, 2020 • edited Loading

JacksonKearl commented Mar 10, 2020

igolskyi commented Mar 10, 2020

kolpav commented Mar 11, 2020

andyd0 commented Mar 11, 2020

yume-chan commented Mar 11, 2020

JacksonKearl commented Mar 11, 2020

dwelle commented Mar 12, 2020

JacksonKearl commented Mar 12, 2020

blakeprudhomme commented Mar 19, 2020

PJUllrich commented Mar 25, 2020

JacksonKearl commented Mar 25, 2020

akbarsha03 commented Mar 26, 2020

d-akara commented Apr 6, 2017 •

edited

Loading

rfgamaral commented Apr 6, 2017 •

edited

Loading

FezVrasta commented May 22, 2017 •

edited

Loading

3zzy commented Aug 23, 2017 •

edited

Loading

fatihacet commented Sep 28, 2017 •

edited

Loading

pxwee5 commented Oct 3, 2017 •

edited

Loading

aneilbaboo commented Jan 6, 2018 •

edited

Loading

JacksonKearl commented Feb 25, 2020 •

edited

Loading

cafesanu commented Mar 2, 2020 •

edited

Loading

igolskyi commented Mar 10, 2020 •

edited

Loading