Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of tslib #25612

Closed
jrieken opened this issue Apr 28, 2017 · 1 comment
Closed

Make use of tslib #25612

jrieken opened this issue Apr 28, 2017 · 1 comment
Assignees
@jrieken
Labels
debt Code quality issues
Milestone
May 2017

Comments

@jrieken
Copy link
Member

jrieken commented Apr 28, 2017

TypeScript generates lots of helpers for inheritance et al. They bloat up our code. We have some fragile regex tricks to remove unnecessary code. Since TypeScript support has gotten a lot better we should make use of tslib and the new emit flags
@jrieken jrieken self-assigned this Apr 28, 2017
@jrieken jrieken added the debt Code quality issues label Apr 28, 2017
@jrieken jrieken added this to the May 2017 milestone Apr 28, 2017
@jrieken jrieken mentioned this issue May 3, 2017
Closed
@jrieken
Copy link
Member Author

jrieken commented May 4, 2017

Closing this without action because the fix for #24770 will check that our current solution works and leaving out helper at compile time will make development harder. Removing waste at bundling is the right point in time

@jrieken jrieken closed this as completed May 4, 2017
@kieferrm kieferrm mentioned this issue May 8, 2017
Closed
44 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
debt Code quality issues
Projects
None yet
Milestone
May 2017
Development

No branches or pull requests
1 participant
@jrieken