Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[theming] when completing color keys in settings, fill in current value #25633

Closed
bpasero opened this issue Apr 28, 2017 · 2 comments · Fixed by #213451
Closed

[theming] when completing color keys in settings, fill in current value #25633

bpasero opened this issue Apr 28, 2017 · 2 comments · Fixed by #213451
Assignees
@aeschli
Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2024

Comments

@bpasero
Copy link
Member

bpasero commented Apr 28, 2017

That would be very helpful 👍
@bpasero bpasero added feature-request Request for new features or functionality themes Color theme issues labels Apr 28, 2017
@cleidigh cleidigh mentioned this issue Apr 30, 2017
Closed
@aeschli aeschli added this to the Backlog milestone May 2, 2017
@aeschli aeschli changed the title Theming: when completing color keys in settings, fill in current value [theming] when completing color keys in settings, fill in current value Nov 27, 2017
This was referenced Oct 29, 2019
Closed
Closed
@aeschli aeschli mentioned this issue Mar 2, 2020
Closed
@usernamehw usernamehw mentioned this issue Mar 16, 2021
Closed
@bpasero bpasero mentioned this issue Aug 15, 2022
Closed
@hediet
Copy link
Member

hediet commented Aug 16, 2022

Is this hard to implement? Otherwise, I'd love to help here.

@aeschli
Copy link
Contributor

aeschli commented Aug 26, 2022 •
edited
Loading

@hediet The completions are schema driven. The schema is generated here: https://github.com/microsoft/vscode/blob/main/src/vs/platform/theme/common/colorRegistry.ts#L127
Instead of ff0000, the color value would come from IThemeService.getColorTheme().getColor(id).
onDidChangeSchema needs be triggered whenever the colorTheme changes (IThemeService.onDidColorThemeChange)
I guess the challenge is how to get the IThemeService to the colorRegistry.

@aeschli aeschli mentioned this issue Oct 10, 2022
Closed
@aeschli aeschli mentioned this issue Jan 31, 2024
Closed
@SimonSiefke SimonSiefke mentioned this issue May 25, 2024
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jun 5, 2024
@aeschli aeschli modified the milestones: Backlog, June 2024 Jun 5, 2024
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 5, 2024
@Yoyokrazy Yoyokrazy added the verification-needed Verification of issue is requested label Jun 25, 2024
@bpasero bpasero added the verified Verification succeeded label Jun 25, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2024
Development

Successfully merging a pull request may close this issue.

When completing color keys in settings, fill in current value SimonSiefke/vscode
5 participants
@bpasero @hediet @aeschli @Yoyokrazy @vscodenpa