[0.10.7] Pane highlight outline

[SamVerschueren]

Since the insider build, it looks like the panes can be highlighted when clicked. It really looks weird to me and doesn't have added value (but maybe there is). Is this a bug or not?

[bpasero]

@SamVerschueren this is part of our ongoing work to be more accessible: #2108

Indicating the currently focused element is a requirement to be accessible. You can see this in action when tabbing around the UI with the tab key.

As to wether the affordance we show is good or bad, I assign this to UX for discussion.

[bpasero]

The added value is Accessibility :]

[SamVerschueren]

Aha, makes sense :). Would it be possible to make it an option (which is default on) to turn this behaviour off?

[bpasero]

Yeap maybe. For now I like that everyone sees it and can report feedback on it.

[SamVerschueren]

👍

[SamVerschueren]

Might be more difficult. I like the highlighting when navigating with tabs. It's very clear what item is selected. But when I start debugging something, the the highlighted pane is automatically switched 3 times in a very short timespan which makes it very weird. Think we should just get the discussion going on how we can improve these things.

[bpasero]

@SamVerschueren can you capture from where to where it moves?

[SamVerschueren]

I thought I saw it when debugging, but it seems that it occurs when running my vscode-yo plugin.

[bpasero]

@SamVerschueren I see, the issue is that the picker closes, focus moves back to where it was and then back into the picker.

The blue line that you see for output is not a focus indicator actually, so you might get confused there easily.

[bpasero]

It also only happens if no file is open because with a opened file, focus moves back to the file when quick picker closes.

[SamVerschueren]

The blue line that you see for output is not a focus indicator actually, so you might get confused there easily.

Oh I see, you're right. The output panel never gets focus, although you get the idea that it receives focus because it switches so quickly.

It also only happens if no file is open because with a opened file, focus moves back to the file when quick picker closes.

Confirmed

But it just looks weird. Maybe I have to get used to it :).

[bpasero]

Some things pushed and thoughts:

• closing quick open no longer restores focus to the viewlet if no editor is open
• we think about not coloring the output panel in blue but in a less strong color that does not interfere with focus
• I went over many places in the tree where we quickly removed focus from the tree which results in the large blue border and relaxed that so that it does not happen that often anymore

I am closing this one and would like to hear more feedback.

[SamVerschueren]

Thanks! Will post some feedback if it gets released.