Cannot open a folder under my OneDrive folder

[DanTravison]

I can use Code to open individual files under my OneDrive folder but attempts to open folders does nothing. Attempts to open the OneDrive folder directly does not result in an open folder but creates a new Onedrive file instead.

• VSCode Version: 1.12.2
• OS Version:10.0.16204 Pro and 10.0.16202 Server

Steps to Reproduce:
There are 3 repos:
Repro 1:

1. Navigate to a folder under OneDrive from a command prompt.
2. Launch code via 'code .'
3. Code launches but no folder is open.

Repro 2:

1. Launch Code
   2: Select File/Open Folder
   3: Navigate to a folder under OneDrive and open it.
   4: No folder is opened.

Repro 3:
1: Launch Code
2: Select File/Open Folder
3: Navigate to the Onedrive folder and select it.
4: No folder is opened but an empty 'OneDrive' file is created in the editor.
NOTE: The same occurs when running 'code .' from the OneDrive folder, an empty Onedrive file is created in the editor

[roblourens]

Does it work normally with other editors?

[bpasero]

Please see if you can find any logged output that could help us find the source of the issue:

• run code --verbose from the command line and attach the output
• in Code select Help | Toggle Developer Tools and select the Console
• attach any output you see in the Console you can find

Thanks!

[dantraMSFT]

I'm seeing a series of lstat errors in the console. Here are the details...

[uncaught exception]: Error: EINVAL: invalid argument, lstat 'D:\OneDrive'

Error: EINVAL: invalid argument, lstat 'D:\OneDrive'
onError @ index.js:40
(anonymous) @ index.js:109
emitOne @ events.js:96
emit @ events.js:188
window.onerror @ C:\Program Files (x86)\Microsoft VS Code\resources\electron.asar\renderer\init.js:124
i.globals.onerror @ errorTelemetry.ts:64
index.js:43Error: EINVAL: invalid argument, lstat 'D:\OneDrive'

Error: EINVAL: invalid argument, lstat 'D:\OneDrive'
at file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:22576
onError @ index.js:43
(anonymous) @ index.js:109
emitOne @ events.js:96
emit @ events.js:188
window.onerror @ C:\Program Files (x86)\Microsoft VS Code\resources\electron.asar\renderer\init.js:124
i.globals.onerror @ errorTelemetry.ts:64
errors.ts:33Uncaught Error: EINVAL: invalid argument, lstat 'D:\OneDrive'

Error: EINVAL: invalid argument, lstat 'D:\OneDrive'
at file:///C:/Program Files (x86)/Microsoft VS Code/resources/app/out/vs/workbench/electron-browser/workbench.main.js:28:22576

[bpasero]

@dantraMSFT I just tried to reproduce with my OneDrive folder and could not. Would you be willing to try to reproduce this running out of sources? As outlined here: https://github.com/Microsoft/vscode/wiki/How-to-Contribute#build-and-run-from-source

[bpasero]

@DanTravison @dantraMSFT @chenxizhang @kevin12314 can you please try again with our insider build from today and report back any errors you see?

You can give our preview releases a try from: http://code.visualstudio.com/Download#insiders

[dantraMSFT]

Doing so now.

[yzhang-gh]

Same here (cannot open folder in OneDrive, will open a new file with the folder name)
(cannot even open a file, will just open a new empty file. Notepad works well)

No error in console. But there is a alert popup "Path doesn't exist on disk" when opening file/folder by Open File/Folder menus.

Windows Insider Preview build 16215
Visual Studio Code Version 1.14.0-insider
Commit c89a5f6
Date 2017-06-15T05:13:32.497Z

[yzhang-gh]

I suspect Files On-Demand feature is to blame.

[bpasero]

@dantraMSFT any update trying insiders? do you have this "Files on demand" feature enabled?

[chenxizhang]

Still not work correctly @bpasero

[bpasero]

@chenxizhang can you open the developer tools (Help > Toggle Developer Tools) and in the console type this:

require("fs").statSync("...")

Where ... is the path to the folder in OneDrive to open and send back the result?

[kevin12314]

My result：

[bpasero]

Ok thanks so it looks like there is literally nothing we can do when node already fails.

[ernestgwilsonii]

THIS SUCKS. It took me hours to find this thread after going insane. Visual Studio Code cannot "open folders" on OneDrive for me either. It looks like OneDrive got updated and broke VSCode. I cannot get back into the Files On-Demand settings in OneDrive to disable that feature. Anyone know how to get this back working again?

[bpasero]

@ernestgwilsonii suggest to contact OneDrive support to see if they have an answer.

@DanTravison @dantraMSFT @chenxizhang @kevin12314 @ernestgwilsonii just to be clear, you are all using the new OneDrive feature "Files On-demand" right?

[ernestgwilsonii]

Here are the facts from my end:
The issue with Visual Studio Code only presents itself while storing my code on OneDrive enabled locations on my PC.
My solution:
STOP using OneDrive and start using Google Drive.
Visual Studio Code is working fine now and OneDive is now in my rear view mirror.

[yzhang-gh]

By disabling Files On-Demand, vscode works again.
(Right click the OneDrive tray icon, and click 'Settings')

[zhangyz1997]

Still not working. Win 10 16273.1000+VSCode 1.16.0 (x64)

[bpasero]

@ChrisWarwick which exact Windows version are you on? Did you verify the scenario works with the "Files on-demand" feature enabled in OneDrive?

[pinoelefante]

@bpasero
Win 10 16275.1000+VSCode 1.15.1 (x86)
Still not working :(

[jeevcat]

Not working for me either. I disabled files-on-demand and resynced and it didn't improve the situation.
Windows 10 16273
VSCode 1.15.1 (x64)

[refack]

• a new libuv release with this fix
• a new node.js release with that libuv version
• a new electron release including that node.js version

The good news is the fix landed in libuv 1.14.0 (libuv/libuv@e5024c5), so 1 of 3 is done.

A version bump PR is open in node - nodejs/node#14866
Should land soon (that'll be 2 of 3).

Then the pressure will be on Electron...

[bpasero]

I just created a build of VS Code that includes Electron 1.7.7 which includes a backport of the fix in libuv (thanks for the backport @zcbenz). Can people hitting the OneDrive issue maybe give this build a try and report back if the problem is fixed?

Thanks

[pinoelefante]

@bpasero is working with this build

[linanw]

Ya, it works. I tested it on Windows 10 build 16251.
Updated:
My Windows later updated to 16278.rs3, it doesn't work any more.

[bpasero]

That is good news. Unfortunately we are closing for our 1.16 release this week and it is unlikely that we would include this Electron version in the stable release. But we plan to update Electron for insiders next week asap so that people have a workaround by using VS Code insiders.

[MaximoTrinidad]

I think someone make sure to test this on the latest Windows 10 Insider Build 16257.rs3. Just in case!
The reason I'm mentioning about it is due to the fact that OneDrive gets updated in one of the recent releases.

:)

[zhangyz1997]

Worked in build 16273 RS4

[bk147]

Also works here on Windows 10 Ent build 16353.rs_prerelease and OneDrive build 17.3.6998.0830 :-)

[bpasero]

Fixed via electron/electron#10377

[bpasero]

Marking as verified based on user testing.