Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge Browser Monaco editor cursor error #2802

Closed
Bigbrd opened this issue Feb 8, 2016 · 2 comments
Closed

Edge Browser Monaco editor cursor error #2802

Bigbrd opened this issue Feb 8, 2016 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone

Comments

@Bigbrd
Copy link

Bigbrd commented Feb 8, 2016

monacoerror

There were numerous incidences where on the Monaco code editor, the user would click at the end of a line and the cursor was not placed where they clicked. These only repro-ed on Edge Browser.

@alexdima alexdima self-assigned this Feb 8, 2016
@alexdima alexdima added the bug Issue identified by VS Code Team member as probable bug label Feb 8, 2016
@alexdima alexdima added this to the Feb 2016 milestone Feb 11, 2016
@alexdima
Copy link
Member

We do feature detection for hit testing, in the following order: document.caretRangeFromPoint, document.caretPositionFromPoint and finally document.body.createTextRange.

It looks like Edge decided to implement document.caretRangeFromPoint, which it didn't support before, but it implemented it in a broken way.

@alexdima alexdima added the important Issue identified as high-priority label Feb 24, 2016
@alexdima
Copy link
Member

Edge's implementation is not necessarily broken, it is a matter of interpretation. Edge sometimes returns a token's <span> as the hit container and sometimes a token's text node, while Chrome always returns a token's text node

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants