Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow changing the selection using the TreeDataProvider #28338

Closed
orta opened this issue Jun 9, 2017 · 7 comments
Closed

Allow changing the selection using the TreeDataProvider #28338

orta opened this issue Jun 9, 2017 · 7 comments
Assignees
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality tree-views Extension tree view issues
Milestone

Comments

@orta
Copy link
Contributor

orta commented Jun 9, 2017

  • VSCode Version: 0.13.0
  • OS Version: macOS 10.12.x

Steps to Reproduce:

  1. Write an extension that uses the TreeDataProvider API to show a UI
  2. Desire to be able to set the selected state programatically

I built an extension ( more details are in #28325 ) and in doing so, I really started wanted to be able to set the selection state programatically.

@sandy081 sandy081 self-assigned this Jun 9, 2017
@sandy081 sandy081 added api file-explorer Explorer widget issues feature-request Request for new features or functionality labels Jun 9, 2017
@sandy081 sandy081 added this to the Backlog milestone Jun 9, 2017
@bpasero bpasero added tree-views Extension tree view issues and removed file-explorer Explorer widget issues labels Nov 27, 2017
@mike-lischke
Copy link

mike-lischke commented Jan 21, 2018

Any chance we get this in a soonish timeframe? The custom view (TreeDataProvider) interface exists now for while but is still very limited (no formatting, no tooltips, no per-node icons, no programmatic interaction like this selection change, expand state, no checkboxes, no columns etc.).

Extension writers could do a lot of cool things if we would be given the necessary APIs. Since these views are a major navigation element in vscode, I think they should get much more love from the vscode devs.

@sandy081
Copy link
Member

sandy081 commented Feb 6, 2018

@mike-lischke

TreeDataProvider api supports icons for nodes. May I know what do you mean by per-node icons?

Also Can you please elaborate about fomatting request?

@mike-lischke
Copy link

mike-lischke commented Feb 6, 2018

Well, it's pretty easy. A good start would be to give us all the possibilities the file tree has got:

  1. It has icons per file type (hence per-tree-node-icons). We want that too.
  2. It has colors for text, also a want-to-have. Markup support, like we have for tooltips in the code editor, would be awesome.
  3. We need to show additional informations per node with a tooltip (at least long text should be shown there).
  4. We must be able to select nodes (yes: multi selection) per code and read out the current status.
  5. Check box support is also a pretty common requirement.
  6. Multi column support is something I need as well. This content:

tokens

would then show much nicer. All the individual values nicely aligned.

  1. Finally, the views should support docking, so that they can be spread accross all the available space. Currently I have 10 views stacked vertically. Even on a 4K screen this is all but easy to consume.

However, this list goes much further than the simple selection request. If you want I can open a new Github issue.

@mike-lischke
Copy link

I guess my list should go to #27823. Then we could close this issue here.

@sandy081 sandy081 modified the milestones: Backlog, February 2018 Feb 14, 2018
@sandy081
Copy link
Member

This issue considers only the API for programatically selecting tree items. I would request to create separate/different issues for each of the requirements/bugs, otherwise it will be difficult to track and am afraid that some of the requests are lost. Thanks for understanding.

I am working on a proposed API for this which will be available for authors to try out in this iteration and the plan to make it available in main API is in next milestone.

@sandy081
Copy link
Member

@orta This request is similar to the issue #30288. Is it ok, if I make this as a dup of #30288 as there is some conversation happened there?

@orta
Copy link
Contributor Author

orta commented Feb 14, 2018

Yep 👍

@orta orta closed this as completed Feb 14, 2018
@sandy081 sandy081 added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality tree-views Extension tree view issues
Projects
None yet
Development

No branches or pull requests

4 participants