Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: How to support both 0.10.7-insider and 0.10.8 with same package? #2894

Closed
daviwil opened this issue Feb 10, 2016 · 8 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality *question Issue represents a question, should be posted to StackOverflow (VS Code)
Milestone

Comments

@daviwil
Copy link
Contributor

daviwil commented Feb 10, 2016

Just released an update of the PowerShell extension and it seems I set my engine field in a way that blocks people using the Insider build from using it. Should I be using 0.10.7-insider as the engine so that semver allows 0.10.8 also?

@alexdima
Copy link
Member

IMHO, I think we need to be smart about compatibility and not update or install an incompatible extension (given current running vscode instance version).

@daviwil
Copy link
Contributor Author

daviwil commented Feb 10, 2016

Definitely, but there are cases like this where one package could work for both mainline and Insider builds. Would the alternative be a convention where extensions need a separate Insider version of their own? I can see some benefits to that approach but I think it'd create extra work for extension authors.

@unuunc
Copy link

unuunc commented Feb 11, 2016

should not this be like a range attribute , like supported from version a to b.

@joaomoreno
Copy link
Member

@daviwil Code doesn't currently respect the engine at installation time. This will be fixed in February. Currently, it will always install the latest published version.

@alexandrudima What is the full allowed syntax of the engine value? Does it support ranges?

@joaomoreno joaomoreno added this to the Feb 2016 milestone Feb 11, 2016
@joaomoreno joaomoreno added *question Issue represents a question, should be posted to StackOverflow (VS Code) feature-request Request for new features or functionality labels Feb 11, 2016
@egamma egamma mentioned this issue Feb 11, 2016
97 tasks
@SamVerschueren
Copy link
Contributor

Node allows ranges as documented https://docs.npmjs.com/files/package.json#engines.

{ 
    "engines" : { 
        "node" : ">=0.10.3 <0.12" 
    }
}

Would be nice if it was supported the same way.

{ 
    "engines" : { 
        "vscode" : ">=0.10.3 <0.10.6" 
    }
}

@joaomoreno
Copy link
Member

Related to commit c06d578

@joaomoreno
Copy link
Member

Code will now only install compatible versions.

@daviwil
Copy link
Contributor Author

daviwil commented Feb 19, 2016

Great, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality *question Issue represents a question, should be posted to StackOverflow (VS Code)
Projects
None yet
Development

No branches or pull requests

6 participants