-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: How to support both 0.10.7-insider and 0.10.8 with same package? #2894
Comments
IMHO, I think we need to be smart about compatibility and not update or install an incompatible extension (given current running vscode instance version). |
Definitely, but there are cases like this where one package could work for both mainline and Insider builds. Would the alternative be a convention where extensions need a separate Insider version of their own? I can see some benefits to that approach but I think it'd create extra work for extension authors. |
should not this be like a range attribute , like supported from version a to b. |
@daviwil Code doesn't currently respect the engine at installation time. This will be fixed in February. Currently, it will always install the latest published version. @alexandrudima What is the full allowed syntax of the |
Node allows ranges as documented https://docs.npmjs.com/files/package.json#engines. {
"engines" : {
"node" : ">=0.10.3 <0.12"
}
} Would be nice if it was supported the same way. {
"engines" : {
"vscode" : ">=0.10.3 <0.10.6"
}
} |
Related to commit c06d578 |
Code will now only install compatible versions. |
Great, thank you! |
Just released an update of the PowerShell extension and it seems I set my
engine
field in a way that blocks people using the Insider build from using it. Should I be using0.10.7-insider
as the engine so that semver allows 0.10.8 also?The text was updated successfully, but these errors were encountered: