Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can a debug adapter indicate variables with possible-side-effects/expensive? #31995

Closed
DanTup opened this issue Aug 3, 2017 · 7 comments
Closed
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Milestone

Comments

@DanTup
Copy link
Contributor

DanTup commented Aug 3, 2017

Currently my Dart debugger only shows fields from objects in debugging tooltips (no properties/getters) to avoid executing user code or causing side effects (that's the behaviour of the debugger, not my adapter, though I understand why they've done it).

I believe I could get these values from the debugger by executing the getters but it could be slow/cause side effects.

Is there a way when returning objects to provide variables that require user-input to evaluate? Similar to how in Visual Studio you can expand iterators when debugging but they're not executed automatically?

I saw microsoft/vscode-node-debug#14 which seemed like it might be related, but I didn't understand the resolution after clicking through the related cases. I also found the expensive flag on Scope but couldn't figure out if that would be useful here.

@vscodebot vscodebot bot added the debug Debug viewlet, configurations, breakpoints, adapter issues label Aug 3, 2017
@DanTup
Copy link
Contributor Author

DanTup commented Aug 3, 2017

I need to get me a @vscodebot[bot], I think it could automate half of what I do at work =D

@weinand
Copy link
Contributor

weinand commented Aug 3, 2017

If you enable "evaluate" based hovers, you could use the "context" argument to decide whether the "evaluate" is used for the variables view or the hover. With this info you could ignore properties/getters for the hover, but include them for the variables view.
Without enabling "evaluate" based hovers, VS Code will use the variables view's data for the hover as well.

@DanTup
Copy link
Contributor Author

DanTup commented Aug 3, 2017

@weinand I actually want both to behave the same, rather just have user input to invoke any getter. I could probably take it by hiding then inside an object that needs expanding, but I think it'd probably look rather misleading?

@weinand
Copy link
Contributor

weinand commented Aug 3, 2017

and with "user input" you mean a context menu action?

@weinand weinand added the feature-request Request for new features or functionality label Aug 3, 2017
@DanTup
Copy link
Contributor Author

DanTup commented Aug 3, 2017

Or some icon or something. Similar to in Visual Studio's refresh button like this:

ic851786

Something simple a user has to do to invoke the getter (both to avoid unwanted side-effects and also for performance reasons, since I need to send individual requests for each getter to the debugger to get their values).

@isidorn
Copy link
Contributor

isidorn commented Aug 4, 2017

This is a nice feature request which is not on our immediate plan -> backlog.
Also one of those things which to me does not feel like it belongs in a minimalstic code editor like VSCode.

@isidorn isidorn added this to the Backlog milestone Aug 4, 2017
@weinand weinand modified the milestones: September 2017, Backlog Sep 5, 2017
@weinand weinand modified the milestones: September 2017, On Deck Sep 26, 2017
@weinand weinand modified the milestones: On Deck, Backlog Nov 14, 2017
@isidorn isidorn added the *out-of-scope Posted issue is not in scope of VS Code label Nov 17, 2017
@vscodebot
Copy link

vscodebot bot commented Nov 17, 2017

This issue has been closed because the feature it requests is not within the scope of the product. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Nov 17, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Development

No branches or pull requests

3 participants