Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickOpen (Ctrl+P) search matching logic needs to be improved #33247

Closed
kumarharsh opened this issue Aug 28, 2017 · 3 comments
Closed

QuickOpen (Ctrl+P) search matching logic needs to be improved #33247

kumarharsh opened this issue Aug 28, 2017 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Milestone

Comments

@kumarharsh
Copy link
Contributor

kumarharsh commented Aug 28, 2017

  • VSCode Version: 1.16-insider
  • OS Version: Windows 10

If I have a file with path: ui/src/ui/Icons/index.js
and there are other files, such as: ui/src/utils/constants.js, etc...

image
after scrolling about 49 or so entries, I get the match I need:
image

Then, searching for ui/Icons puts the more relevant ui/src/ui/Icons path somewhere way down the list, not what I'd expect. I'd expect a matches with longer runs to be higher rated, no? It seems like this was (partially) fixed somewhere in previous builds because I always type these kind of path and stopped getting miffed with the results - they were not perfect, but they were passable, But lately I'm finding myself getting miffed again, so I think this bug is a regression?

Maybe possibly linked: #20546

Reproduces without extensions: Yes

@kumarharsh
Copy link
Contributor Author

Another demo which paints a more stark picture for the need of a better ranking:

image

The ui/input/index.js should be at the top - it has matches ALL of the search string, and should be the highest ranked. No idea why paths which match only bits and pieces of the search string show up at the top.

@chrmarti chrmarti removed the insiders label Sep 27, 2017
@bpasero
Copy link
Member

bpasero commented Oct 3, 2017

#34210

@bpasero bpasero closed this as completed Oct 3, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 3, 2017
@kumarharsh
Copy link
Contributor Author

#27317

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants