Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[folding] Expand action should restore cursor position inside folded region iff cursor didn't change since fold action #3484

Closed
joaomoreno opened this issue Feb 26, 2016 · 1 comment
Closed

[folding] Expand action should restore cursor position inside folded region iff cursor didn't change since fold action #3484

joaomoreno opened this issue Feb 26, 2016 · 1 comment
Assignees
@joaomoreno
Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality verified Verification succeeded
Milestone
March 2016

Comments

@joaomoreno
Copy link
Member

Confusing, but let me elaborate. Before #3400, I could run Fold Fold Fold actions in a deeply nested folding region and then Expand Expand Expand and my cursor would return back to the original position.

Although #3400 is the good fix, it did remove that functionality unfortunately.

Maybe there is a way for the actions to cooperate between themselves and have the expand action restore the cursor position iff it hasn't changed since the fold action.
@joaomoreno joaomoreno added the feature-request Request for new features or functionality label Feb 26, 2016
@joaomoreno joaomoreno added this to the Backlog milestone Feb 26, 2016
@aeschli aeschli added the editor-folding Editor code folding issues label Mar 4, 2016
@unional unional mentioned this issue Mar 8, 2016
Closed
@aeschli
Copy link
Contributor

aeschli commented Mar 8, 2016

Fixed by #3814

@aeschli aeschli closed this as completed Mar 8, 2016
@aeschli aeschli modified the milestones: March 2016, Backlog Mar 8, 2016
@joaomoreno joaomoreno assigned joaomoreno and unassigned aeschli Mar 8, 2016
@joaomoreno joaomoreno added the verified Verification succeeded label Mar 18, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
editor-folding Editor code folding issues feature-request Request for new features or functionality verified Verification succeeded
Projects
None yet
Milestone
March 2016
Development

No branches or pull requests
2 participants
@joaomoreno @aeschli