Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode hangs when expanding folder with 200K files #34841

Closed
innerlee opened this issue Sep 22, 2017 · 6 comments
Closed

Vscode hangs when expanding folder with 200K files #34841

innerlee opened this issue Sep 22, 2017 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues perf tree-widget Tree widget issues

Comments

@innerlee
Copy link
Contributor

  • VSCode Version: 1.16.1
  • OS Version: Ubuntu 16.04

There are also around 200K error messages in the developer console, says something like

ipc.cp.ts:164 [IPC Library: Watcher] Error: watch /mnt/SSD/datasets/202585.jpg ENOSPC

Reproduces without extensions: Yes

@bpasero
Copy link
Member

bpasero commented Sep 25, 2017

@bpasero bpasero added this to the Backlog milestone Sep 25, 2017
@bpasero bpasero added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Sep 25, 2017
@innerlee
Copy link
Contributor Author

After increasing the max_user_watches limit, it still hangs with the following error

Maximum call stack size exceeded: RangeError: Maximum call stack size exceeded
    at t.onInsertItems (file:///usr/share/code/resources/app/out/vs/workbench/workbench.main.js:28:218597)
    at t.onItemExpanded (file:///usr/share/code/resources/app/out/vs/workbench/workbench.main.js:28:721646)
    at t.onModelEvents (file:///usr/share/code/resources/app/out/vs/workbench/workbench.main.js:28:717366)
    at file:///usr/share/code/resources/app/out/vs/workbench/workbench.main.js:28:716809
    at r (file:///usr/share/code/resources/app/out/vs/workbench/workbench.main.js:28:90777)
    at t.e._emitToBulkListeners (file:///usr/share/code/resources/app/out/vs/workbench/workbench.main.js:28:92856)
    at t.e._emitEvents (file:///usr/share/code/resources/app/out/vs/workbench/workbench.main.js:28:92938)
    at file:///usr/share/code/resources/app/out/vs/workbench/workbench.main.js:28:92185
    at r (file:///usr/share/code/resources/app/out/vs/workbench/workbench.main.js:28:90777)
    at t.e._emitToBulkListeners (file:///usr/share/code/resources/app/out/vs/workbench/workbench.main.js:28:92856)
e.onUnexpectedError @ /usr/share/code/resources/app/out/vs/workbench/workbench.main.js:29

@bpasero
Copy link
Member

bpasero commented Sep 28, 2017

Smells like tree @joaomoreno

@joaomoreno
Copy link
Member

Strange, that method isn't even recursive.

@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Nov 6, 2017
@bpasero bpasero added perf tree-widget Tree widget issues labels Nov 15, 2017
@bpasero bpasero removed this from the Backlog milestone Nov 15, 2017
@agauniyal
Copy link

Call stack contains other things eg. arguments passed to it which could exceed call stack size as well so it might be something else than recursion...

@joaomoreno
Copy link
Member

#18180

@joaomoreno joaomoreno added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 23, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues perf tree-widget Tree widget issues
Projects
None yet
Development

No branches or pull requests

5 participants