Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breakpoint section doesn't show breakpoints initially #35179

Closed
weinand opened this issue Sep 26, 2017 · 5 comments
Closed

Breakpoint section doesn't show breakpoints initially #35179

weinand opened this issue Sep 26, 2017 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Sep 26, 2017

  • VSCode Version: Insiders 1.17 a5210bc
  • OS Version: macOS

Steps to Reproduce:

  • install mock-debug extension
  • create a breakpoint in a foo.md file

Observe:
Breakpoint shows up in gutter and BREAKPOINTS view

  • restart or reload VS Code

Observe:
Breakpoint section is expanded but doesn't show breakpoints.

  • add another breakpoint

Observe:
both breakpoints show up

@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Sep 26, 2017
@weinand weinand added this to the September 2017 milestone Sep 26, 2017
@vscodebot vscodebot bot added the insiders label Sep 26, 2017
@weinand weinand changed the title Breakpoint section doesn't show breakpoints initally Breakpoint section doesn't show breakpoints initially Sep 26, 2017
@isidorn
Copy link
Contributor

isidorn commented Sep 27, 2017

I can not reproduce this with my latest fixes linked in the other issue thus closing.
Please let me know if you can still reproduce this, thank you.

@isidorn isidorn closed this as completed Sep 27, 2017
@weinand weinand reopened this Sep 28, 2017
@weinand
Copy link
Contributor Author

weinand commented Sep 28, 2017

I can still reproduce this.

@weinand weinand removed this from the September 2017 milestone Sep 28, 2017
@isidorn isidorn added this to the October 2017 milestone Sep 28, 2017
@isidorn
Copy link
Contributor

isidorn commented Sep 28, 2017

For some reason I do not see this on my machine. Due to that I believe it is a timing issue. Might the split view ask me too early about the size
@joaomoreno did we change something with our split view refactoring that could affect this?

@joaomoreno
Copy link
Member

joaomoreno commented Sep 28, 2017

Possible... Check the code that sets the view size and make sure it sets it right.

@isidorn isidorn closed this as completed in 88a2fba Oct 3, 2017
@isidorn
Copy link
Contributor

isidorn commented Oct 3, 2017

I believe 1804467 has introduced this issue. Looking at the code I am suspect the setting of 0 as the size in the constructor. I believe I have addresed this issue with the commit, however since I could not originaly reporduce this issue will wait for @weinand to check.

@roblourens roblourens added the verified Verification succeeded label Nov 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants