-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort recently opened files by recency after I start typing #35610
Comments
This issue is INCREDIBLY annoying and affects almost all users many many times during each day. Please add this to the backlog 🙏🏻 |
This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
+1 |
🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation. Happy Coding! |
72a3816 added a new setting |
Maybe I am misunderstanding the solution but In my opinion this should be a mix of both. I.e in the example given the search result list should be exactly like it is apart from the recently opened /user-portal/client/README.md being at the top. With that settings I don't see anyone needing a settings change as I cant imagine anyone wanting to change that behaviour. Another option would have been to do it like it is done in Sublime. There they don't change the list order (like VSCode does now). But instead they auto highlight the most recently opened file in the search results list. I actually find that solution quite elegant after looking into it :) I any case I am happy to see something being done about this issue, good job! 👏 |
@olitomas to clarify, quick search for files in VSCode exists of 2 buckets: recently opened and all other files of the workspace that were not recently opened. Typing to search will show results from recently opened instantly and search results later (because they need to go do to disk and do the actual search). Both buckets are sorted differently, but with this change more as you would expect: unless sorting by recency is enabled, the results in recently opened are sorted like the file results (they still appear on top though because they come first). With this new option you can strictly sort by how recently you opened a file. I think this helpful in exactly the scenario where you type the filename of a file that has many entries with the same name. |
Verification
|
In quick open (
ctrl+p
) the recently opened files are sorted by recency only until I start typing, then scoring is used instead (only when two files get the same score, recency is used again, see #20546 (comment)).This is unpleasant on repositories with many files of the same name, for example, we have many READMEs in our monorepo and it's unintuitive why filtering in the recently opened list should change the sort order, or in a bad case, move the item completely out of sight:
I think the natural behavior would be just to sort by recency in this list.
Related issues:
The text was updated successfully, but these errors were encountered: