Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort recently opened files by recency after I start typing #35610

Closed
borekb opened this issue Oct 5, 2017 · 8 comments
Closed

Sort recently opened files by recency after I start typing #35610

borekb opened this issue Oct 5, 2017 · 8 comments
Assignees
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@borekb
Copy link

borekb commented Oct 5, 2017

In quick open (ctrl+p) the recently opened files are sorted by recency only until I start typing, then scoring is used instead (only when two files get the same score, recency is used again, see #20546 (comment)).

This is unpleasant on repositories with many files of the same name, for example, we have many READMEs in our monorepo and it's unintuitive why filtering in the recently opened list should change the sort order, or in a bad case, move the item completely out of sight:

image

image

I think the natural behavior would be just to sort by recency in this list.

Related issues:

@vscodebot vscodebot bot added the workbench label Oct 5, 2017
@bpasero bpasero added feature-request Request for new features or functionality quick-pick Quick-pick widget issues labels Oct 5, 2017
@bpasero bpasero removed their assignment Oct 5, 2017
@bpasero bpasero removed the workbench label Nov 14, 2017
@bpasero bpasero added this to the Backlog Candidates milestone Oct 24, 2019
@olitomas
Copy link

olitomas commented Dec 8, 2019

This issue is INCREDIBLY annoying and affects almost all users many many times during each day. Please add this to the backlog 🙏🏻

@vscodebot
Copy link

vscodebot bot commented Jan 22, 2020

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@acidofil
Copy link

+1

@vscodebot
Copy link

vscodebot bot commented Jan 22, 2020

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@bpasero
Copy link
Member

bpasero commented Mar 22, 2020

72a3816 added a new setting "search.quickOpen.history.filterSortOrder": "recency" that allows to strictly sort by recency in the history list. The default remains to sort by filter relevance.

@bpasero bpasero closed this as completed Mar 22, 2020
@olitomas
Copy link

Maybe I am misunderstanding the solution but In my opinion this should be a mix of both. I.e in the example given the search result list should be exactly like it is apart from the recently opened /user-portal/client/README.md being at the top.

With that settings I don't see anyone needing a settings change as I cant imagine anyone wanting to change that behaviour.

Another option would have been to do it like it is done in Sublime. There they don't change the list order (like VSCode does now). But instead they auto highlight the most recently opened file in the search results list. I actually find that solution quite elegant after looking into it :)

I any case I am happy to see something being done about this issue, good job! 👏

@bpasero
Copy link
Member

bpasero commented Mar 23, 2020

@olitomas to clarify, quick search for files in VSCode exists of 2 buckets: recently opened and all other files of the workspace that were not recently opened. Typing to search will show results from recently opened instantly and search results later (because they need to go do to disk and do the actual search).

Both buckets are sorted differently, but with this change more as you would expect: unless sorting by recency is enabled, the results in recently opened are sorted like the file results (they still appear on top though because they come first).

With this new option you can strictly sort by how recently you opened a file. I think this helpful in exactly the scenario where you type the filename of a file that has many entries with the same name.

@bpasero bpasero added the verification-needed Verification of issue is requested label Mar 28, 2020
@bpasero
Copy link
Member

bpasero commented Mar 28, 2020

Verification

  • configure "search.quickOpen.history.filterSortOrder": "recency"
  • verify that when you start typing in quick open, the results show in the same order for the "recently opened" as they appear when nothing is typed

@JacksonKearl JacksonKearl added the verified Verification succeeded label Apr 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality quick-pick Quick-pick widget issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants