Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzy searching problem #36119

Closed
Jackie-Yang opened this issue Oct 12, 2017 · 10 comments
Closed

fuzzy searching problem #36119

Jackie-Yang opened this issue Oct 12, 2017 · 10 comments
Assignees
Labels
quick-pick Quick-pick widget issues search Search widget and operation issues

Comments

@Jackie-Yang
Copy link

  • VSCode Version: Code 1.17.1 (1e9d365, 2017-10-10T14:24:50.851Z)
  • OS Version: Windows_NT x64 10.0.15063
  • Extensions:
Extension Author (truncated) Version
cpptools ms- 0.13.1
sublime-keybindings ms- 2.9.1

Steps to Reproduce:

If I want to fuzzy search "File.cpp" under "ABC" folder (using Ctrl + P), input "ABC File.cpp",
The search results might be:
"Axx\xxBxx\xxC\xxxxx\File.cpp"

The search results are inaccurate, most importantly, I didn't get the results I needed.
The searching performance of sublime text is still better than vscode.

Reproduces without extensions: Yes/No

@vscodebot vscodebot bot added the search Search widget and operation issues label Oct 12, 2017
@roblourens
Copy link
Member

It's hard to know what you mean in that case if there are other fuzzy matches, but if you use abc/file.cpp, then it should only show the result under a folder 'abc'.

@roblourens roblourens assigned bpasero and unassigned roblourens Oct 12, 2017
@roblourens
Copy link
Member

Assigning @bpasero if you want to tweak it or follow up

@Jackie-Yang
Copy link
Author

@roblourens
for example:
Target path: xxx/xxx/abc/xxx/xxx/file.cpp
Input: abc file.cpp
result: axxx/bxxx/cxxx
VScode:
1-1

Sublime:
2-2

@bpasero
Copy link
Member

bpasero commented Oct 13, 2017

@Jackie-Yang did a little bit of tweaks here for our 1.18 insider build, can you grab it and see if your examples work any better? You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@bpasero bpasero added the quick-pick Quick-pick widget issues label Oct 13, 2017
@bpasero
Copy link
Member

bpasero commented Oct 13, 2017

@Jackie-Yang also in your screenshot where you compare VS Code with Sublime I see different folders for the top results, are those not showing up for VS Code after all? I mean the ones within projects/ui/tcl/...

@Jackie-Yang
Copy link
Author

@bpasero Yes, so I said I didn't get the results I needed.
The results of VScode did not include "tcl" folder.

@bpasero
Copy link
Member

bpasero commented Oct 16, 2017

@Jackie-Yang not at all or just showing up later? Is this workspace open source so that I could have a look?

@Jackie-Yang
Copy link
Author

Jackie-Yang commented Oct 16, 2017

@bpasero
Sorry~This code is not open source
But I try it again, and it show correctly, maybe the index build error?
And I want to know is it the index rebuilt sometimes? Sometimes the result show quickly, and sometimes it need to load.
Can vscode show index progress like sublime?

@Jackie-Yang
Copy link
Author

@bpasero But this problem still exist, it still show wrong result when I search some file.
My workspace is to big, so I try to input the whole path of the file, and it need to load for a long time, so I think vscode did not index all the file at that time.

@bpasero
Copy link
Member

bpasero commented Oct 20, 2017

Fixed via 9d40f0c

@bpasero bpasero closed this as completed Oct 20, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 4, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
quick-pick Quick-pick widget issues search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

4 participants