Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal should support workbench.fontAliasing #36249

Open
Tyriar opened this issue Oct 13, 2017 · 11 comments
Open

Terminal should support workbench.fontAliasing #36249

Tyriar opened this issue Oct 13, 2017 · 11 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Milestone
Backlog

Comments

@Tyriar
Copy link
Member

Tyriar commented Oct 13, 2017

#2577
https://twitter.com/_developit/status/918488307968937984
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Oct 13, 2017
@Tyriar Tyriar added the feature-request Request for new features or functionality label Oct 13, 2017
@Tyriar Tyriar added this to the Backlog milestone Oct 13, 2017
@Tyriar Tyriar added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Dec 28, 2017
@Tyriar Tyriar mentioned this issue Jan 30, 2018
Closed
@Tyriar
Copy link
Member Author

Tyriar commented Jan 30, 2018

We may be able to leverage the new allowTransparency xterm.js option to force SPAA off.

@ghost
Copy link

ghost commented Jan 31, 2018

So happy! Yay! 🕺

@marcos-diaz
Copy link

I use workbench.fontAliasing: none and terminal ignoring it makes me sad

@Khalilw1
Copy link

Khalilw1 commented Jul 5, 2018

Is there any news on this feature ? My font get antialiased everywhere except in the terminal 😢

@Tyriar
Copy link
Member Author

Tyriar commented Jul 5, 2018

@Khalilw1 your terminal has no AA? Can you post a screenshot?

@Khalilw1
Copy link

Khalilw1 commented Jul 5, 2018

I want it be not AA I already set my workbench to none for this
screen shot 2018-07-05 at 4 51 48 pm

@Tyriar
Copy link
Member Author

Tyriar commented Jul 5, 2018 •
edited
Loading

Ah I see, you want no AA. No update on this

@Khalilw1
Copy link

Khalilw1 commented Jul 5, 2018

@Tyriar Is there any feature request or is there an way to tweak xterm to make it work (I understand that xterm is the used terminal right ?). Thank you for your time

@Tyriar
Copy link
Member Author

Tyriar commented Jul 5, 2018

@Khalilw1 this would indeed need a change in xterm.js to draw to the canvas without AA enabled

@outpoints
Copy link

Is it possible to have this on Windows?

@Tyriar Tyriar mentioned this issue Oct 10, 2019
Open
@Tyriar
Copy link
Member Author

Tyriar commented Oct 10, 2019

Upstream issue: xtermjs/xterm.js#2464

@Tyriar Tyriar added upstream-issue-linked This is an upstream issue that has been reported upstream and removed intergrated-terminal-xtermjs labels Oct 10, 2019
@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Sep 1, 2021
@Tyriar Tyriar modified the milestones: Backlog, January 2023 Dec 22, 2022
@Tyriar Tyriar added terminal-rendering and removed terminal General terminal issues that don't fall under another label labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@Tyriar @marcos-diaz @Khalilw1 @outpoints @meganrogge