Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend 'findFiles' to allow multiple patterns #38545

Closed
roblourens opened this issue Nov 16, 2017 · 3 comments
Closed

Extend 'findFiles' to allow multiple patterns #38545

roblourens opened this issue Nov 16, 2017 · 3 comments
Assignees
@roblourens @jrieken
Labels
api feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code

Comments

@roblourens
Copy link
Member

Extended glob patterns are unlikely to be supported: #10851

So allowing an array of patterns would be easy to support and make those scenarios much easier to deal with.
@roblourens roblourens added the api label Nov 16, 2017
@roblourens roblourens mentioned this issue Nov 16, 2017
Closed
@jrieken jrieken added the under-discussion Issue is under discussion for relevance, priority, approach label Nov 17, 2017
@jrieken
Copy link
Member

jrieken commented Nov 17, 2017

Don't we support glob-patterns like these {foo,bar}?

@roblourens
Copy link
Member Author

Given the comment in #10851, I wonder if that isn't discoverable, or if arrays would be easier to work with.

@roblourens roblourens mentioned this issue Apr 27, 2018
Open
@jrieken jrieken added feature-request Request for new features or functionality and removed under-discussion Issue is under discussion for relevance, priority, approach labels Sep 11, 2018
@roblourens
Copy link
Member Author

I don't think many people are asking for this, not worth changing API for it

@roblourens roblourens added the *out-of-scope Posted issue is not in scope of VS Code label Sep 11, 2018
@KamasamaK KamasamaK mentioned this issue Feb 3, 2019
Closed
@roblourens roblourens mentioned this issue Mar 5, 2019
Closed
@andreamah andreamah mentioned this issue Dec 16, 2022
Closed
@lewisl9029 lewisl9029 mentioned this issue Apr 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roblourens roblourens

@jrieken jrieken

Labels
api feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @jrieken