Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to contribute and run a command when Double Clicking on a node in custom views #39601

Closed
roblourens opened this issue Dec 5, 2017 · 4 comments
Assignees
Labels
api feature-request Request for new features or functionality tree-views Extension tree view issues

Comments

@roblourens
Copy link
Member

roblourens commented Dec 5, 2017

Requested use case needs ability to contribute and run a command when Double Clicking on a node in custom views

From @changsi-an on December 5, 2017 2:3

After a node debug session is launched. I cannot pin a script file in the text editor by double-clicking it. While I can do so for the files in the Explorer viewlet.

A work around to pin a document is to double-click its tab in the text editor after it's opened. (At the same time the font changes from italic to normal).

Copied from original issue: microsoft/vscode-node-debug2#155

@roblourens
Copy link
Member Author

This would need support from the custom tree view extension API. Since we're using it as a second file explorer, it would be nice to be able to implement other file explorer features for it.

@roblourens roblourens added tree-views Extension tree view issues feature-request Request for new features or functionality labels Dec 5, 2017
@roblourens roblourens assigned octref and unassigned roblourens Dec 5, 2017
@octref octref assigned sandy081 and unassigned octref Dec 5, 2017
@roblourens
Copy link
Member Author

cc @weinand

@sandy081 sandy081 added this to the Backlog milestone Dec 5, 2017
@fernandoescolar
Copy link

I have a (ugly) workaround for this issue: https://github.com/fernandoescolar/vscode-solution-explorer/blob/master/src/commands/OpenFileCommand.ts

But It would be great if the treeitem could have different events like the doubleclick one.

@sandy081 sandy081 changed the title Double click on a file entry in **LOADED SCRIPTS** does not pin a document in the text editor. Ability to contribute and run a command when Double Clicking on a node in custom views May 23, 2018
@sandy081 sandy081 added the api label May 23, 2018
@sandy081 sandy081 modified the milestones: Backlog, June 2018 Jun 19, 2018
@sandy081 sandy081 removed this from the June 2018 milestone Jun 20, 2018
@sandy081
Copy link
Member

After discussions we decided not to expose double click command.

There should be only one command and executing this command on single click or double click is up to application. There is a setting workbench.list.openMode to configure this behaviour.

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality tree-views Extension tree view issues
Projects
None yet
Development

No branches or pull requests

4 participants