Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not require a line in problem reports #39919

Closed
doudou opened this issue Dec 8, 2017 · 2 comments · Fixed by #39936
Closed

do not require a line in problem reports #39919

doudou opened this issue Dec 8, 2017 · 2 comments · Fixed by #39936
Assignees
@dbaeumer
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@doudou
Copy link
Contributor

doudou commented Dec 8, 2017

  • VSCode Version: 1.18.0
  • OS Version: Ubuntu 16.04 LTS

Problem matchers currently must provide a line (and will be ignored if they don't). There's however sometimes problems that have no lines, where assuming a line of 1 would be just fine IMO.
@vscodebot vscodebot bot added the editor label Dec 8, 2017
@isidorn isidorn removed the editor label Dec 8, 2017
@doudou doudou mentioned this issue Dec 8, 2017
Merged
@sandy081 sandy081 assigned dbaeumer and unassigned sandy081 Dec 8, 2017
@doudou doudou mentioned this issue Dec 8, 2017
Merged
@dbaeumer dbaeumer added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 11, 2017
@vscodebot
Copy link

vscodebot bot commented Dec 11, 2017

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@dbaeumer
Copy link
Member

Dups #6538

@vscodebot vscodebot bot closed this as completed Dec 11, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbaeumer dbaeumer

Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

allow for problem patterns without a line doudou/vscode
4 participants
@doudou @isidorn @dbaeumer @sandy081