Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto show tag suggestions when you type < in jsx #40539

Closed
mjbvz opened this issue Dec 20, 2017 · 8 comments
Closed

Auto show tag suggestions when you type < in jsx #40539

mjbvz opened this issue Dec 20, 2017 · 8 comments
Assignees
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Dec 20, 2017

From #24524

Feature Request
Automatically show tag suggestions when you type < in a jsx file

@mjbvz mjbvz added feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues labels Dec 20, 2017
@mjbvz mjbvz self-assigned this Dec 20, 2017
@mjbvz
Copy link
Collaborator Author

mjbvz commented Dec 20, 2017

We would likely only want to enable this for cases like:

(
    <div>
        <|
    </div>
)

where the user is typing inside of jsx already. Otherwise, we would risk triggering on the less than operator <

@mjbvz
Copy link
Collaborator Author

mjbvz commented Apr 3, 2018

Depends on microsoft/TypeScript#21012

@mjbvz mjbvz added this to the May 2018 milestone Apr 3, 2018
@mjbvz mjbvz added the verification-needed Verification of issue is requested label May 1, 2018
@mjbvz mjbvz closed this as completed in 9f16378 May 1, 2018
@roblourens
Copy link
Member

I don't understand what I should see. Seems the same as 1.23

@mjbvz
Copy link
Collaborator Author

mjbvz commented May 30, 2018

Thanks for taking a look @roblourens. This only applies if you are inside of a jsx context already. For example try typing < at the | in:

const a = <div>
	|
</div>

After typing the < you should now automatically see suggestions

@roblourens
Copy link
Member

Oh I do see it in jsx but not in tsx, is that right?

@roblourens
Copy link
Member

Actually, I see it in tsx in one case. But it seems kind of flaky. Trying in several files, it seems like it works in some and not others.

@roblourens
Copy link
Member

may-30-2018 22-08-58

@roblourens
Copy link
Member

But then after reloading the window it worked

@octref octref added the verified Verification succeeded label May 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants