Improve diff editor title when comparing files

[joaomoreno]

Related to #3954

Maybe we could use the subtitle part to show the folders, like:

tK4ZY9_monkey.txt ↔ monkey.txt - /private/var/folders/lr/b36df5dx0y7cy_mywg5r623800000gn/T, /Users/joao/Work/fakeproject

[bpasero]

I thought about replacing the path with something shorter if it is actually a substring of the tmp path (e.g. $tmp/).

[joaomoreno]

Why 👎 when we are actually doing it across the product?

[bpasero]

@joaomoreno we used to have what you suggest and I always felt it was hard to read what exactly is being compared so I chose the easiest thing that could possibly work and just show 2 full paths. the issue here is the ugly tmp path, I did not hear complaints otherwise.

[joaomoreno]

That's cause no one uses the Compare with action 💃

Likewise, I think it looks awkward here:

[bpasero]

Nah, how do you think I got so many points on SO: http://stackoverflow.com/questions/30139597/visual-studio-code-is-there-a-compare-feature-like-that-plugin-for-notepad

;)

[bpasero]

I still think in any case it would help to replace the long tmp path with something short.

[bpasero]

Examples where imho it does not work:

Comparing a workspace local file to out of workspace

Comparing root level file to other file

@stevencl @bgashler1 maybe you have some ideas

[bpasero]

@joaomoreno I also think in your case it makes no sense to show xyz_monkey.txt, I think it would make more sense to allow for the --diff parameter to set a label for the left hand side so that the context from where this file is from becomes clear (e.g. the commit hash or message).

[joaomoreno]

+1 on labels, git even supports that such that it would appear as Theirs and Ours in the UI

[bpasero]

Closing in favour of #4452