Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keybindings - Show Conflict - label is confusing #41541

Closed
egamma opened this issue Jan 12, 2018 · 3 comments
Closed

Keybindings - Show Conflict - label is confusing #41541

egamma opened this issue Jan 12, 2018 · 3 comments
Assignees
@sandy081
Labels
feature-request Request for new features or functionality keybindings-editor Keybinding editor issues verified Verification succeeded
Milestone
January 2018

Comments

@egamma
Copy link
Member

egamma commented Jan 12, 2018 •
edited
Loading

The Show Conflicts action made me expect that this action filters or groups the key bindings which have conflicts. However, the action really does a find for the same key binding that is currently selected. For this reason I suggest to rename the action to ´Find same keybinding´.
@egamma egamma added the keybindings-editor Keybinding editor issues label Jan 12, 2018
@sandy081 sandy081 added the feature-request Request for new features or functionality label Jan 15, 2018
@sandy081 sandy081 added this to the January 2018 milestone Jan 15, 2018
@egamma egamma changed the title Keybindings - make the Show Conflict action easier discoverable. Keybindings - Show Conflict - label is confusing Jan 15, 2018
@ramya-rao-a
Copy link
Contributor

@sandy081 Is this still meant for the January milestone? If not, can you move it to February milestone?

@sandy081
Copy link
Member

It's just a label change, I would like to push it in this milestone.

@sandy081
Copy link
Member

I am calling this action Show Same Keybindings as it shows all entries with same keybindings. Any changes/improvements are welcome.

@sandy081 sandy081 added the verification-needed Verification of issue is requested label Jan 31, 2018
@aeschli aeschli added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
feature-request Request for new features or functionality keybindings-editor Keybinding editor issues verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@egamma @aeschli @sandy081 @ramya-rao-a