Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restoreWindows setting ignored #42062

Closed
fonnesbeck opened this issue Jan 23, 2018 · 7 comments
Closed

restoreWindows setting ignored #42062

fonnesbeck opened this issue Jan 23, 2018 · 7 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster workbench-state UI state across restarts

Comments

@fonnesbeck
Copy link

fonnesbeck commented Jan 23, 2018

This is an ongoing problem first described in #41039, which was not re-opened when I noticed the problem had continued, so I am opening a new issue.

  • VSCode Version: Code 1.19.2 (490ef76, 2018-01-10T15:49:04.682Z)
  • OS Version: Darwin x64 17.4.0
  • Extensions:
Extension Author (truncated) Version
latex-workshop Jam 3.12.3
django-html bib 1.2.0
django-snippets bib 1.1.0
jupyter don 1.1.4
python-extension-pack don 1.0.1
file-icons fil 1.0.7
shell-format fox 1.1.1
mdmath goe 2.1.0
Python-autopep8 him 1.0.2
nbpreviewer jit 1.0.0
MagicPython mag 1.0.12
python ms- 0.9.1
jinja who 0.0.8
markdown-pdf yza 0.1.7
markdown-all-in-one yzh 1.0.3

(6 theme extensions excluded)


Steps to Reproduce:

  • Open files with vscode
  • Set the following preference "window.restoreWindows": "none"
  • Close vscode
  • Restart vscode
  • Observe previous documents open, despite setting
  • When I open a new session under the setting above, I expect no open windows, yet previous windows always appear on startup.

I have tried using insider builds, but the problem still arises.

Reproduces without extensions: Yes

@fonnesbeck
Copy link
Author

I have also tried setting:

"window.reopenFolders": "none"

but the issue continues

@bpasero
Copy link
Member

bpasero commented Jan 24, 2018

@fonnesbeck are you starting code from the command line with "code ."?

@bpasero bpasero added the info-needed Issue requires more information from poster label Jan 24, 2018
@fonnesbeck
Copy link
Author

It is. Can this be turned off?

@bpasero
Copy link
Member

bpasero commented Jan 24, 2018

@fonnesbeck so what is the issue here then. You ask code to open a folder and it opens, what else would you expect?

@fonnesbeck
Copy link
Author

fonnesbeck commented Jan 24, 2018

Sorry for not being clear. I do expect the folder to open up, but what I did not expect is the 2 or 3 files that I happened to have open the last time (including some not from that folder) to also be opened. It appears to be restoring a session, and not just giving me access to the folder.

So for example, if I call code . in one of my repositories, I get this:

which shows the folder in the sidebar (I expect this), but also 5 files from the last session, which I am not interested in seeing.

Whereas, if I run code . in a folder that I have not recently used vscode in, I get this:

This is what I would expect when I set "window.restoreWindows": "none" -- no windows restored.

@bpasero bpasero added the workbench-state UI state across restarts label Jan 25, 2018
@bpasero
Copy link
Member

bpasero commented Jan 25, 2018

/duplicate #22613

@vscodebot vscodebot bot added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 25, 2018
@vscodebot
Copy link

vscodebot bot commented Jan 25, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Jan 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) info-needed Issue requires more information from poster workbench-state UI state across restarts
Projects
None yet
Development

No branches or pull requests

2 participants