Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming first folder restarts extension host #42625

Closed
chrmarti opened this issue Jan 31, 2018 · 2 comments
Closed

Renaming first folder restarts extension host #42625

chrmarti opened this issue Jan 31, 2018 · 2 comments
Assignees
@bpasero @sandy081
Labels
api debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s) workbench-multiroot Multi-root (multiple folders) issues
Milestone
February 2018

Comments

@chrmarti
Copy link
Collaborator

Issue Type

Bug

Description

Testing #42195

Shouldn't be necessary to restart the extension host when only the name of the first folder changed, should it?

VS Code Info

VS Code version: Code - Insiders 1.20.0-insider (010de7d, 2018-01-31T09:45:32.303Z)
OS version: Linux x64 3.13.0-108-generic

Reproduces without extensions
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Jan 31, 2018
@bpasero bpasero added this to the January 2018 milestone Jan 31, 2018
@bpasero
Copy link
Member

bpasero commented Jan 31, 2018

This is a consequence of only having methods to add or remove folders but not to update them (to change their name). Imho not a big deal though.

/cc @sandy081

@bpasero bpasero added api workbench-multiroot Multi-root (multiple folders) issues labels Jan 31, 2018
@bpasero bpasero removed this from the January 2018 milestone Jan 31, 2018
@bpasero bpasero added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Jan 31, 2018
@sandy081 sandy081 self-assigned this Jan 31, 2018
@bpasero bpasero mentioned this issue Jan 31, 2018
Closed
@bpasero bpasero added this to the February 2018 milestone Jan 31, 2018
@bpasero
Copy link
Member

bpasero commented Feb 4, 2018

This is actually the same as #42639

@bpasero bpasero closed this as completed Feb 4, 2018
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 4, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@sandy081 sandy081

Labels
api debt Code quality issues *duplicate Issue identified as a duplicate of another issue(s) workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
3 participants
@bpasero @chrmarti @sandy081