Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for regexp in files shows results only from open files #43081

Closed
acristu opened this issue Feb 7, 2018 · 3 comments
Closed

Searching for regexp in files shows results only from open files #43081

acristu opened this issue Feb 7, 2018 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone

Comments

@acristu
Copy link

acristu commented Feb 7, 2018

  • VSCode Version:1.19.3 (7c4205b)
  • OS Version: Microsoft Windows [Version 10.0.15063]

I ran into #32095 while searching using regexp.

Steps to Reproduce:

  1. Regular search for name: "
  2. Occurrences in all files are found
  3. Search using regexp for \{(?:\s|\r?\n)*?name: "(\w+)",
  4. Only occurrences in open files are found

Does this issue occur when all extensions are disabled?: Yes

No errors in Developer Tools Console.

@vscodebot vscodebot bot added the search Search widget and operation issues label Feb 7, 2018
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label Feb 7, 2018
@roblourens roblourens added this to the February 2018 milestone Feb 7, 2018
@roblourens
Copy link
Member

roblourens commented Feb 7, 2018

Multiline search is not supported, so it should show an error message for that query (because of the \n) but it was getting swallowed. It will now show "Literal \n not allowed"

@acristu
Copy link
Author

acristu commented Feb 9, 2018

Could we have an option to allow multiline search, disabled by default?

@roblourens
Copy link
Member

It's just not implemented. #13155

@tsalinger tsalinger added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants