Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lift the 60 chars limit on the camel case matcher #43338

Closed
nachocab opened this issue Feb 9, 2018 · 3 comments
Closed

Lift the 60 chars limit on the camel case matcher #43338

nachocab opened this issue Feb 9, 2018 · 3 comments
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code quick-pick Quick-pick widget issues

Comments

@nachocab
Copy link

nachocab commented Feb 9, 2018

Issue Type

Bug

Description

Let's say I have two classes that share some part of their names:

screen shot 2018-02-09 at 12 26 16

I can access them correctly on the quick panel, but when I type a letter that matches the end of the long name, the long class disappears from the quick panel:

screen shot 2018-02-09 at 12 26 25

VS Code Info

VS Code version: Code 1.20.0 (c63189d, 2018-02-07T17:02:34.244Z)
OS version: Darwin x64 17.3.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz (8 x 2300)
Load (avg) 3, 2, 2
Memory (System) 16.00GB (0.27GB free)
Process Argv /Applications/Visual Studio Code.app/Contents/MacOS/Electron
Screen Reader no
VM 0%
Reproduces without extensions
@octref octref added search-replace Search and replace issues quick-pick Quick-pick widget issues and removed search-replace Search and replace issues labels Feb 12, 2018
@bpasero
Copy link
Member

bpasero commented Feb 13, 2018

This is because our camel case matcher is limited to 60 characters length for performance reasons.

@bpasero bpasero changed the title Long symbol names get dropped Lift the 60 chars limit on the camel case matcher Feb 13, 2018
@bpasero bpasero added the feature-request Request for new features or functionality label Feb 13, 2018
@bpasero bpasero removed their assignment Feb 13, 2018
@nachocab
Copy link
Author

Ah, that explains it. Being able to extend that to at least the line length (120) would make a huge difference for some of my files 👍

@bpasero bpasero added the *out-of-scope Posted issue is not in scope of VS Code label Oct 10, 2019
@vscodebot
Copy link

vscodebot bot commented Oct 10, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality *out-of-scope Posted issue is not in scope of VS Code quick-pick Quick-pick widget issues
Projects
None yet
Development

No branches or pull requests

3 participants