Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing split terminals makes content wrap weirdly, no way to get back #44666

Closed
ramya-rao-a opened this issue Feb 27, 2018 · 6 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Feb 27, 2018

Testing #44446 in Mac

Below, I split the terminal 4 times. Then picked one of the boundaries between 2 of the resulting terminals and moved left and right. All text flows around weirdly and getting the size back to the original size doesn't make the text go back to the original layout

terminal-use-flow

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Feb 27, 2018
@Tyriar
Copy link
Member

Tyriar commented Feb 28, 2018

Pretty sure the weird text on the right that's hanging around is because of the temporary "reflow" workaround of keeping the text around when the terminal's resized but not shown, so that particular problem will probably be fixed with #23688.

@Tyriar
Copy link
Member

Tyriar commented Feb 28, 2018

This issue made me realize this is the first time terminals can go below like 30 columns or so due to the minimum width of the panel.

@Tyriar
Copy link
Member

Tyriar commented Feb 28, 2018

Good news (I guess) is I can pretty easily break the most popular Linux terminal by fiddling with narrow widths when the prompt is up:

image

@Tyriar
Copy link
Member

Tyriar commented Feb 28, 2018

We seem to do about as good of a job with this as other terminals (checked gnome-terminal, terminator, iterm), it's just we allow the terminal to be more narrow then them. I think I'll increase the min width even more and call this a shell bug 😃

@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Feb 28, 2018
@Tyriar Tyriar added this to the February 2018 milestone Feb 28, 2018
@Tyriar Tyriar closed this as completed in ba9f6a8 Feb 28, 2018
@Tyriar
Copy link
Member

Tyriar commented Feb 28, 2018

To verifier: check that the min width is larger (120px) and the situation has improved as a result.

@gushuro gushuro added the verified Verification succeeded label Mar 1, 2018
@gushuro
Copy link
Contributor

gushuro commented Mar 1, 2018

I see the improvement and the min width increase.
There's still unexpected behavior when getting a terminal size back to the original. That's being tracked on #23688

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants