Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split terminal should remain same width #45331

Closed
octref opened this issue Mar 8, 2018 · 5 comments
Closed

Split terminal should remain same width #45331

octref opened this issue Mar 8, 2018 · 5 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Milestone

Comments

@octref
Copy link
Contributor

octref commented Mar 8, 2018

Issue Type: Bug

Currently, toggle sidebar or using a tool like https://www.spectacleapp.com/ to resize VS Code will both make terminal have unequal width.

VS Code version: Code - Insiders 1.21.0-insider (a903bd3, 2018-03-06T10:59:55.398Z)
OS version: Darwin x64 17.3.0

terminal

@octref octref added the terminal Integrated terminal issues label Mar 8, 2018
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Mar 8, 2018
@Tyriar Tyriar added this to the March 2018 milestone Mar 8, 2018
@theigor
Copy link

theigor commented Mar 16, 2018

Thumbs up for this. Terminals should have same relative width when you resize the window. If I have 3 terminals and resize the window, they should remain 33% width each. It would be acceptable (I think) if manual terminal width change should cancel this behavior until you get back down to 1 terminal. That is, if I have 2 terminals and manually resize them so one is 25% of the width, I don't expect vs code to figure out what that should mean if I resize the window. But if I close one, and then split again, it should spit to 50/50 and keep the relative % width if I resize.

@crhistianramirez
Copy link

crhistianramirez commented Mar 20, 2018

I'm probably being picky but adding on to @theigor's post I think the manual resize scenario should be considered.

@theigor
Copy link

theigor commented Mar 22, 2018

I'll add another tidbit - this is especially annoying when I drag vscode from one monitor to another. Not only does it bungle all my terminals, but it seems that some output is word wrapped but some isn't so the whole thing becomes a mess and even when I resize it back, not everything that was word wrapped restores back. I end up with things like this:

image

@Tyriar
Copy link
Member

Tyriar commented Mar 22, 2018

@theigor if you're on mac/Linux this issue should fix the problem #23688, planning on working on that soon. It should work on Windows eventually but needs some changes inside Windows.

@theigor
Copy link

theigor commented Mar 22, 2018

Sounds good. I'm seeing this on Windows right now.

@Tyriar Tyriar closed this as completed in 4cc6cf5 Mar 22, 2018
@mjbvz mjbvz added the verified Verification succeeded label Mar 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants