Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve commands in "terminal.integrated.env.*" #45692

Closed
RichyHBM opened this issue Mar 13, 2018 · 6 comments
Closed

Resolve commands in "terminal.integrated.env.*" #45692

RichyHBM opened this issue Mar 13, 2018 · 6 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label

Comments

@RichyHBM
Copy link

  • VS Code version: Code 1.21.0 (9a199d7, 2018-03-07T11:01:43.521Z)
  • OS version: Linux x64 4.15.0-10-generic

Steps to Reproduce:

  1. set a settings variable to make use of a command
  2. observe that command isnt resolved to its value

Does this issue occur when all extensions are disabled?: Yes

Example:
Having the Golang extension, or any other extension that provides commands:

{
    "go.inferGopath": true,
    "terminal.integrated.env.linux": {
        "GOPATH": "${command:go.gopath}"
    }
}

$ env
...
GOPATH=${command:go.gopath}
...

I believe this is similar to #34337 which was fixed in #40059 by @ramya-rao-a by processing the env: and config:, but it does not process commands

@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Mar 13, 2018
@Tyriar
Copy link
Member

Tyriar commented Mar 15, 2018

@ramya-rao-a do you know what it would mean to resolve commands? I think you could do this with ${env:GOPATH}, no?

@ramya-rao-a
Copy link
Contributor

@Tyriar

${env:GOPATH} would point to the gopath in the env of the renderer process
The Go extension has in built logic to determine the go path (which can be different from ${env:GOPATH}) which can be displayed to the user using the Go: Current GOPATH command

@RichyHBM

I believe you are asking for a generic feature where you want to use the output of any command usable in the settings. cc @isidorn for thoughts on that

@RichyHBM
Copy link
Author

@ramya-rao-a My precise use case is for the go extension, but yes this issue is regarding any command

@isidorn
Copy link
Contributor

isidorn commented Mar 16, 2018

I believe you are asking for something like interactive variables
#6569

However debug is the only one supporting interactive variables. If I understand correctly this would be a feature request for the settings to support interactive variables fyi @sandy081

@sandy081
Copy link
Member

sandy081 commented Mar 19, 2018

Here is the request to support resolving env variables in settings - #2809

@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Mar 19, 2018
@Tyriar Tyriar closed this as completed Mar 19, 2018
@vscodebot
Copy link

vscodebot bot commented Mar 19, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators May 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal General terminal issues that don't fall under another label
Projects
None yet
Development

No branches or pull requests

5 participants