Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent driver letters in debugger and integrated terminal #45760

Closed
IgorNovozhilov opened this issue Mar 14, 2018 · 9 comments
Closed

Inconsistent driver letters in debugger and integrated terminal #45760

IgorNovozhilov opened this issue Mar 14, 2018 · 9 comments
Assignees
Labels
*out-of-scope Posted issue is not in scope of VS Code terminal General terminal issues that don't fall under another label under-discussion Issue is under discussion for relevance, priority, approach

Comments

@IgorNovozhilov
Copy link

Inconsistent driver letters in debugger and integrated terminal. see Steps to Reproduce
To work correctly, you need to bring both driver letters, to either lowercase or uppercase.
Otherwise, problems arise when importing modules in NodeJS debug mode, similar to this: webpack/webpack#2362, is when the same module is imported twice and receives different instances executable code

  • VSCode Version:
    Версия 1.22.0-insider
    Фиксация a716373
    Дата 2018-03-14T05:15:41.910Z
    Оболочка 1.7.9
    Отрисовщик 58.0.3029.110
    Узел 7.9.0
    Архитектура x64

  • OS Version: win7 pro

Steps to Reproduce:

  1. run code console.log(require('path').resolve('./test')); in integrated terminal
    image

  2. run code console.log(require('path').resolve('./test')); in debugger
    image

see:
nodejs/node#6624

@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Mar 14, 2018
@IgorNovozhilov
Copy link
Author

Repeated in VSCode
Версия 1.21.0
Фиксация 9a199d7
Дата 2018-03-07T11:04:09.969Z
Оболочка 1.7.9
Отрисовщик 58.0.3029.110
Узел 7.9.0
Архитектура x64

@Tyriar
Copy link
Member

Tyriar commented Mar 15, 2018

I seem to recall it's this way in the terminal for a reason, because some tool was failing when lowercase was being used. @weinand any thoughts on this?

@Tyriar Tyriar added the under-discussion Issue is under discussion for relevance, priority, approach label Mar 15, 2018
@weinand
Copy link
Contributor

weinand commented Mar 15, 2018

@Tyriar VS Code normalizes drive letters to lower case when converting paths into urls and vice versa.

And the VS Code debugger started to do the same in the last milestone (see #43959). So expanded variables use lower case drive letters.

But see my comment #43959 (comment) why this doesn't help in cases where the drive letter casing comes from outside of VS Code.

How do you control the drive letter case in the integrated terminal?

@Tyriar
Copy link
Member

Tyriar commented Mar 15, 2018

/cc @roblourens

@IgorNovozhilov
Copy link
Author

Here's another example where the behavior is different
2018-03-16_07h55_02
2018-03-16_07h55_59

@DonJayamanne

This comment has been minimized.

@weinand
Copy link
Contributor

weinand commented Jan 30, 2019

@DonJayamanne please create a new issue for this.

@vscodebot
Copy link

vscodebot bot commented Oct 8, 2019

This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that are not going to be addressed in the foreseeable future: We look at the number of votes the issue has received and the number of duplicate issues filed. More details here. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.

If you wonder what we are up to, please see our roadmap and issue reporting guidelines.

Thanks for your understanding and happy coding!

@vscodebot vscodebot bot closed this as completed Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
*out-of-scope Posted issue is not in scope of VS Code terminal General terminal issues that don't fall under another label under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

4 participants