Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong keyboard shortcuts suggestions #4677

Closed
che-mauro opened this issue Mar 25, 2016 · 1 comment
Closed

Wrong keyboard shortcuts suggestions #4677

che-mauro opened this issue Mar 25, 2016 · 1 comment
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux verified Verification succeeded
Milestone
March 2017

Comments

@che-mauro
Copy link

  • VSCode Version: 0.10.11
  • OS Version: Ubuntu 15.10

Italian keyboard.

Steps to Reproduce:

  1. Open keyboard shortcuts
  2. Go to key ctrl+/ for example
  3. The suggestion for my italian keyboard is Ctrl + - instead of Ctrl + ù
  4. This happens also for others special characters like [ and so on

screenshot
@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux labels Mar 29, 2016
@alexdima alexdima added the keybindings VS Code keybinding issues label Mar 1, 2017
@alexdima alexdima added this to the Backlog milestone Mar 1, 2017
@alexdima alexdima added the keyboard-layout Keyboard layout issues label Mar 1, 2017
@alexdima
Copy link
Member

I have validated that we now (i.e. after PR #22894 aka #17521 -- in tomorrow's Insiders build) appear to behave correctly for this keyboard layout

image

Analysis of default keybinding for editor.action.commentLine

  • editor.action.commentLine is bound by default to the key code binding ctrl+/
  • / can be produced through one scan code combination: Shift+[Digit7]. i.e.:
    image
  • therefore, the key code binding ctrl+/ is mapped to the scan code binding Ctrl+Shift+[Digit7]. The F1 list now correctly reflects this:
    image
    image
  • That is unfortunate, but correct. We don't ship with keyboard layout specific default keybindings, that is something you can upvote in Support contributing different keybindings based on keyboard layout #1240

This makes me believe the fix in PR #22894 aka #17521 resolves this issue.

@alexdima alexdima modified the milestones: March 2017, Backlog Mar 23, 2017
@roblourens roblourens added the verified Verification succeeded label Mar 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug keybindings VS Code keybinding issues keyboard-layout Keyboard layout issues linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Milestone
March 2017
Development

No branches or pull requests
3 participants
@roblourens @alexdima @che-mauro