Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode Markdown Parser Bug for Extensions README.md #47033

Closed
ahmadawais opened this issue Mar 31, 2018 · 6 comments
Closed

VSCode Markdown Parser Bug for Extensions README.md #47033

ahmadawais opened this issue Mar 31, 2018 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone

Comments

@ahmadawais
Copy link
Contributor

I am about to launch a new theme next week, called Shades of Purple.

The issue is that the README.md file is being parsed completely fine at GitHub and at VSCode Marketplace. But inside VSCode the markup is not being parsed :(

Take a look at this screenshot.

image
image

  • VSCode Version: 1.21.1
Environment:
  OS: macOS Sierra 10.12.6
  CPU: x64 Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz
  Node: 9.7.1
  Yarn: 1.5.1
  npm: 5.7.1
  Watchman: Not Found

Browsers:
  Chrome: 65.0.3325.181
  Chrome Canary: Not Found
  Firefox: 57.0.1
  Firefox Developer Edition: 57.0
  Firefox Nightly: Not Found
  Safari: 11.0
  Safari Technology Preview: Not Found

@vscodebot vscodebot bot added the markdown Markdown support issues label Mar 31, 2018
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Apr 2, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 2, 2018

Bug in marked library. Opened markedjs/marked#1195 to track this upstream

@UziTech
Copy link

UziTech commented Apr 3, 2018

A quick fix would be to put new lines after the end of closing tags. demo

@ahmadawais
Copy link
Contributor Author

Thanks @UziTech for the tip. I did that so the issue is resolved for now but Markedjs could really be improved by this.

@UziTech
Copy link

UziTech commented Apr 3, 2018

Thanks. We are currently trying to raise marked from the dead. Any help would be appreciated. 😁

@ahmadawais
Copy link
Contributor Author

@UziTech I'll see what I can do apart from sharing it with my network 👍

@mjbvz
Copy link
Collaborator

mjbvz commented May 1, 2018

Fixed by picking up a new copy of marked.

For verification, create an extension that has this README.md and preview it in the extension explorer: https://raw.githubusercontent.com/ahmadawais/shades-of-purple-vscode/2828bb0c51ba950790cf3e084475d125205a1921/README.md

Some headers and other content used to show up raw, i.e. as ### header in the output. This should not happen in fixed vscode versions

@mjbvz mjbvz closed this as completed May 1, 2018
@mjbvz mjbvz added this to the May 2018 milestone May 1, 2018
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label May 1, 2018
@dbaeumer dbaeumer added the verified Verification succeeded label May 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants