Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated Terminal glitched output with docker push #47088

Closed
hassanselim0 opened this issue Apr 2, 2018 · 3 comments
Closed

Integrated Terminal glitched output with docker push #47088

hassanselim0 opened this issue Apr 2, 2018 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues

Comments

@hassanselim0
Copy link

hassanselim0 commented Apr 2, 2018

  • VSCode Version: 1.21.1
  • OS Version: Windows 10 Pro Version 1709

Steps to Reproduce:

  1. Run docker push on the integrated terminal while it's small (enough to not show all the layers)
  2. Attempt to scroll while the layers are being uploaded
  3. Notice that lines (with layer progress change) get duplicated

Screenshot: (notice how the c041efd84434 line is duplicated)
image

I don't believe that this is related to #36630 because I don't get that io error and the push completes successfully, but the progress bars glitch in this way.
This issue might apply to other CLI tools that modify previous lines in the console, not just docker push, but I haven't encountered any of these myself so I can't confirm.

Note: I'm using cmd in the integrated terminal, I haven't tested with Powershell.

Does this issue occur when all extensions are disabled?: Probably

@vscodebot vscodebot bot added the terminal Integrated terminal issues label Apr 2, 2018
@hassanselim0 hassanselim0 changed the title Integrated Terminal glitched output with docker Integrated Terminal glitched output with docker push Apr 2, 2018
@Tyriar
Copy link
Member

Tyriar commented Apr 2, 2018

This is one of the issues caused by winpty, tracking in #45693

@Tyriar Tyriar closed this as completed Apr 2, 2018
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Apr 2, 2018
@hassanselim0
Copy link
Author

@Tyriar I'm not sure which of the linked issues in that meta-issue is the duplicate.
My line duplication issue doesn't happen when resizing, it happens when scrolling then a line gets updated (like the progress bar).

@Tyriar
Copy link
Member

Tyriar commented Apr 2, 2018

@hassanselim0 I edited the issue to call this one out explicitly.

@vscodebot vscodebot bot locked and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) terminal Integrated terminal issues
Projects
None yet
Development

No branches or pull requests

2 participants