Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vcxproj] All text within <Command> node should be highlighted as .bat (.cmd) code. #48057

Closed
DmitrySokolov opened this issue Apr 17, 2018 · 6 comments

Comments

@DmitrySokolov
Copy link

Issue Type: Bug

All text within this node

<Command>
echo Text
for /L %%A in (1,1,10) do echo %%A
<Command>

is a valid .bat code. And it should be highlited appropriately.

VS Code version: Code 1.21.1 (79b44aa, 2018-03-14T14:46:47.128Z)
OS version: Windows_NT x64 10.0.16299

System Info
Item Value
CPUs Intel(R) Core(TM) i5 CPU 750 @ 2.67GHz (4 x 2675)
Memory (System) 8.00GB (3.64GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe -r C:\Dev\Projects\ITC\Icad\trunk\IntelliCAD\Source
Screen Reader no
VM 50%
Extensions (3)
Extension Author (truncated) Version
hg mrc 1.2.3
vscode-fileutils sle 2.8.1
cmake twx 0.0.17

(2 theme extensions excluded)

Reproduces without extensions
@ramya-rao-a
Copy link
Contributor

What is the file extension on the file where you have this code?

@DmitrySokolov
Copy link
Author

It's a well known Microsoft Visual Studio project files.

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Apr 17, 2018

@DmitrySokolov vcxproj files use the builtin xml extension. The xml grammar is not aware of any other embedded languages and so cannot provide the appropriate highlighting.

@aeschli Are there any existing feature requests for supporting syntax highlighting of embedded languages as a generic feature?

@aeschli
Copy link
Contributor

aeschli commented Apr 18, 2018

@ramya-rao-a There are requests for generic solutions, but I don't think there is a generic solution.

To get better support for vcxproj, someone should come up with specific support for that file type.
That means implementing a TextMate grammar for vcxproj which can be based on the XML one.

@ramya-rao-a
Copy link
Contributor

@aeschli

There are requests for generic solutions, but I don't think there is a generic solution

I was hoping to get a link to one such feature request so that @DmitrySokolov can understand all the discussions we've had in this topic till now

@ramya-rao-a
Copy link
Contributor

@DmitrySokolov #1751 #670 #46133 #47288 cover most of the discussions in this area

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants