Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language in webview API differs from elsewhere #48593

Closed
Tyriar opened this issue Apr 24, 2018 · 1 comment
Closed

Language in webview API differs from elsewhere #48593

Tyriar opened this issue Apr 24, 2018 · 1 comment
Assignees
Labels
api verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 24, 2018

#48453

Many of the new APIs pose questions in their JS Doc:

		/**
		 * Should the find widget be enabled in the panel?
		 *
		 * Defaults to false.
		 */

Typically we use a statement like this:

		/**
		 * Controls if a cancel button should show to allow the user to
		 * cancel the long running operation.  Note that currently only
		 * `ProgressLocation.Notification` is supporting to show a cancel
		 * button.
		 */
		cancellable?: boolean;
@Tyriar Tyriar added the api label Apr 24, 2018
@mjbvz mjbvz added this to the April 2018 milestone Apr 24, 2018
@mjbvz mjbvz added the verification-needed Verification of issue is requested label Apr 24, 2018
@mjbvz mjbvz closed this as completed in b67472b Apr 24, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Apr 24, 2018

This also affects WebviewOptions

@Tyriar Tyriar reopened this Apr 24, 2018
@mjbvz mjbvz closed this as completed in 568b1c4 Apr 24, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants