Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure preferred quote style for auto imports and generated code #49653

Closed
mjbvz opened this issue May 10, 2018 · 1 comment
Closed

Configure preferred quote style for auto imports and generated code #49653

mjbvz opened this issue May 10, 2018 · 1 comment
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality javascript JavaScript support issues on-testplan typescript Typescript support issues
Milestone
May 2018

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented May 10, 2018

Problem
For auto imports, TS will currently infer the quote style to use (single or double) from other imports in the file. For files without any existing imports, we always default to double quotes

Fix
With TS 2.9, add a new "javascript.preferences.quoteStyle and "typescript.preferences.quoteStyle setting that explicitly sets which quote style to use
@mjbvz mjbvz added feature-request Request for new features or functionality typescript Typescript support issues javascript JavaScript support issues verification-needed Verification of issue is requested labels May 10, 2018
@mjbvz mjbvz added this to the May 2018 milestone May 10, 2018
@mjbvz mjbvz self-assigned this May 10, 2018
@mjbvz
Copy link
Collaborator Author

mjbvz commented May 10, 2018

Fixed by e1a4a68

@mjbvz mjbvz closed this as completed May 10, 2018
@kieferrm kieferrm mentioned this issue May 14, 2018
Closed
46 tasks
@mjbvz mjbvz mentioned this issue May 25, 2018
Closed
3 tasks
@mjbvz mjbvz added on-testplan and removed verification-needed Verification of issue is requested labels May 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality javascript JavaScript support issues on-testplan typescript Typescript support issues
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
1 participant
@mjbvz