Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree.onDidChangeSelection does not fire if selection is cleared #52910

Closed
weinand opened this issue Jun 26, 2018 · 2 comments
Closed

tree.onDidChangeSelection does not fire if selection is cleared #52910

weinand opened this issue Jun 26, 2018 · 2 comments
Assignees
@joaomoreno @sandy081
Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues
Milestone
Backlog

Comments

@weinand
Copy link
Contributor

weinand commented Jun 26, 2018

testing #52806:

  • use https://github.com/weinand/vscode-processes
  • add listener for onDidChangeSelection which outputs the selection
  • F5
  • run "Show Processes View" command
  • in the new window open the integrated terminal
  • in the integrated terminal run a "sleep 1000"
  • in the process viewer select the "sleep 1000" node (which results in a onDidChangeSelection event)
  • in the integrated terminal kill the "sleep" via Control-C

Observe: onDidChangeSelection does not fire
@weinand weinand added bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues labels Jun 26, 2018
@sandy081 sandy081 added tree-views Extension tree view issues and removed tree-widget Tree widget issues labels Jun 27, 2018
@sandy081 sandy081 added this to the June 2018 milestone Jun 27, 2018
@sandy081 sandy081 added tree-widget Tree widget issues and removed tree-views Extension tree view issues labels Jun 27, 2018
@sandy081 sandy081 removed this from the June 2018 milestone Jun 27, 2018
@sandy081
Copy link
Member

Looks like tree is not triggering selection event in this case.

@joaomoreno joaomoreno added this to the Backlog milestone Jun 27, 2018
@joaomoreno
Copy link
Member

I believe this is fixed by now.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug tree-widget Tree widget issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@joaomoreno @weinand @sandy081