Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide easier way to create workspace folder relative uris #52937

Closed
joaomoreno opened this issue Jun 26, 2018 · 1 comment
Closed

Provide easier way to create workspace folder relative uris #52937

joaomoreno opened this issue Jun 26, 2018 · 1 comment
Assignees
Labels
api feature-request Request for new features or functionality uri

Comments

@joaomoreno
Copy link
Member

joaomoreno commented Jun 26, 2018

Testing #52800

It would be much easier to create uris to give to WorkspaceEdit instances if we had utilities to create uris from relative paths inside folders.

Right now I have to do something like this:

vscode.Uri.file(path.join(folder.uri.fsPath, 'foo.js'))

Suggestions:

  • Uri.relative(path: string): Uri
  • WorkspaceFolder.getRelativeUri(path: string): Uri

I know our API isn't supposed to have utils... so I also see the counter argument.

@jrieken jrieken added feature-request Request for new features or functionality api uri labels Jun 26, 2018
@jrieken
Copy link
Member

jrieken commented Jun 26, 2018

Unlikely to happen and I also think it's an artificial need that arises from toying around. I'd say that language brains creating workspace edits are already using absolute paths (maybe uris) so that this need doesn't exist.

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api feature-request Request for new features or functionality uri
Projects
None yet
Development

No branches or pull requests

2 participants