Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revealing a non-existing tree item results in an (unhelpful) error #52944

Closed
weinand opened this issue Jun 26, 2018 · 2 comments
Closed

revealing a non-existing tree item results in an (unhelpful) error #52944

weinand opened this issue Jun 26, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Jun 26, 2018

testing #52806:

If no error occurs (and the breakpoint is not hit), collapse/expand the process view or hide/unhide it.

Observe: you hit the breakpoint and the error message refers to the internal id of the treeitem.

Without the error handler the following massive error shows up in the console:
2018-06-26_13-26-26

IMO the usefulness of the error is questionable.
Since it can always happen that a revealed item has dropped from the tree, installing an error handler seems to be mandatory. But what can be done in the handler other than suppressing the error?

@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Jun 26, 2018
@sandy081
Copy link
Member

Makes sense. Just logging the error and returning a successful promise is good enough.

@sandy081 sandy081 added the tree-views Extension tree view issues label Jun 27, 2018
@sandy081 sandy081 added this to the July 2018 milestone Jun 27, 2018
@JacksonKearl
Copy link
Contributor

JacksonKearl commented Aug 2, 2018

Do you know why I'd be unable to get any breakpoints to verify when debugging the vscode-extension process?

Edit: turns out process needs to be activated for the brakepoint to activate.

@JacksonKearl JacksonKearl added verification-steps-needed Steps to verify are needed for verification verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Aug 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants