Node debug: auto attach mode is not remembered

[egamma]

• enable auto attach using the Toggle Auto Attach command
• reload the window

-> the auto attach statusbar item is gone.

I was wondering whether the auto attach mode would not better be a setting, then I can define per workspace when I want to have the feature enabled.

[weinand]

@egamma The reason why we don't remember this as a setting is because that would require to activate the node-debug extensions on startup (which we are reluctant to do).

[weinand]

see #53640

[egamma]

closing as a duplicate of #53640

[weinand]

I've reopened this issue to track the fixes for the following problems:

• the auto-attach state is now a setting with 3 values: 'disabled', 'on', 'off'. The value 'disabled' hides it from the status bar.
• if the setting is created via the "Toggle Auto Attach", it will be stored in workspace settings.
• restarting remembers the setting's value.

[weinand]

I've created #54183 to address the issue with the settings API.

[weinand]

Verification info:

• the auto-attach state is now a setting with 3 values: 'disabled', 'on', 'off'. The value 'disabled' hides it from the status bar.
• if the setting is created via the "Toggle Auto Attach", it will be stored in workspace settings.
• restarting remembers the setting's value.

Verify that

• the auto-attach setting works as described,
• auto-attach setting can be used in user and workspace settings,
• and is persisted across debug sessions.

[JacksonKearl]

I'm not able to get auto-attach to work on win10 with node v8.11.2 on latest insiders.

I have index.js:

let a = () => setTimeout(() => {
    console.log('ping')
    a();
}, 500);
a();

And when I run node --inspect index.js in either bash or powershell, the program executes but code does not attach

[weinand]

auto-attach failing on Windows issue is unrelated to this issue.
I've created issue #55672 for this.

[weinand]

The "verification needed" is incorrect because found issue #55672 is a new independent issue (that has been verified already).