Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick Open: unhappy spread of highlight in this case #56667

Closed
ris58h opened this issue Aug 17, 2018 · 3 comments
Closed

Quick Open: unhappy spread of highlight in this case #56667

ris58h opened this issue Aug 17, 2018 · 3 comments
Assignees
@bpasero
Labels
*as-designed Described behavior is as designed quick-pick Quick-pick widget issues

Comments

@ris58h
Copy link
Contributor

ris58h commented Aug 17, 2018

Expected highlighting: src/vs/editor/contrib/smartSelect
Actual highlighting: src/vs/editor/contrib/smartSelect

vscode-quick-open-problem

  • VSCode Version: 1.26.0
  • OS Version: Ubuntu 18.04.1 LTS
@vscodebot
Copy link

vscodebot bot commented Aug 17, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the editor label Aug 17, 2018
@sandy081 sandy081 removed the editor label Aug 20, 2018
@bpasero bpasero added the quick-pick Quick-pick widget issues label Aug 20, 2018
@bpasero bpasero mentioned this issue Aug 20, 2018
Open
64 tasks
@bpasero
Copy link
Member

bpasero commented Aug 21, 2018

This is an unfortunate consequence of giving characters that match in the beginning of words a high bonus:

https://github.com/Microsoft/vscode/blob/e1a1e6d6d4e1e64fba2cad3aafbfe5bbc5571824/src/vs/base/parts/quickopen/common/quickOpenScorer.ts#L185

@bpasero bpasero changed the title Quick Open strange highlighting Quick Open: bad spread of highlight in this case Sep 5, 2018
@bpasero bpasero changed the title Quick Open: bad spread of highlight in this case Quick Open: unhappy spread of highlight in this case Sep 5, 2018
@bpasero
Copy link
Member

bpasero commented Sep 10, 2018

Closing as designed, not planning to change this to avoid regressions in other places of the scoring.

@bpasero bpasero closed this as completed Sep 10, 2018
@bpasero bpasero added the *as-designed Described behavior is as designed label Sep 10, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
*as-designed Described behavior is as designed quick-pick Quick-pick widget issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ris58h @bpasero @chrmarti @sandy081