Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: EH debugging #56822

Closed
3 tasks done
isidorn opened this issue Aug 20, 2018 · 0 comments
Closed
3 tasks done

Test: EH debugging #56822

isidorn opened this issue Aug 20, 2018 · 0 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented Aug 20, 2018

Complexity: 3
Refs: #55955, #48377

We have refactored EH debugging to address issues like #55955. Open the hello-world extension (yo generator) in VS Code and verify:

  • You can debug the extension by running it and hitting a breakpoint,
  • Reloading the debuggee vscode window properly reconnects the debug session,
  • You can restart the debuggee from the first window via debug toolbar - results in the reload of the second window. Verify breakpoints after this still get hit,
  • Closing the debuggee vscode windows stops the debug session (toolbar is hidden),
  • You can stop the debug session by clicking the red square in toolbar from the first window which will result in the second window closing,
  • replace the body of the "extension.sayHello" command with code that invokes a command that has a EH reload as a side effect, e.g. this:
          vscode.commands.executeCommand('_workbench.enterWorkspace', vscode.Uri.file('/Users/johndoe/foo/bar.code-workspace')).then(_ => {
              console.log("ok");
          }, e => {
              console.log("error: " + e);
          });
    
    and verify that EH debugging is not blocked (as was seen in the original issue Broken EH debugging on Windows after window reloads  #55916).

After reloading/restarting the EH please make sure that the debugger connects properly to the new EH process by either

  • waiting at least 10 seconds (because that's the timeout after that VS Code shows an error about the EH not running properly), or
  • using any other proof that it runs (e.g. the git extension updates a badge with the number of changed resources)
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item labels Aug 20, 2018
@isidorn isidorn added this to the August 2018 milestone Aug 20, 2018
@sandy081 sandy081 removed their assignment Aug 28, 2018
@joaomoreno joaomoreno removed their assignment Aug 28, 2018
@aeschli aeschli removed their assignment Aug 28, 2018
@aeschli aeschli closed this as completed Aug 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

4 participants