Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings decoration: Modified in Folder #57370

Open
chrmarti opened this issue Aug 28, 2018 · 3 comments
Open

Settings decoration: Modified in Folder #57370

chrmarti opened this issue Aug 28, 2018 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues
Milestone

Comments

@chrmarti
Copy link
Collaborator

chrmarti commented Aug 28, 2018

Issue Type: Feature Request

Testing #57304

There already is a 'Modified in Workspace" decoration, it would be great if that would also list any folders in which that setting is modified (and also show these in the workspace settings).

VS Code version: Code - Insiders 1.27.0-insider (43676d0, 2018-08-28T05:12:24.162Z)
OS version: Darwin x64 17.7.0

@roblourens
Copy link
Member

@sandy081 is there an easy way to find out whether a setting is modified in some folder, or do I need to call inspect for every workspace folder to check? All workspace folders multiplied by all settings could be large, which is why I left this out...

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Aug 29, 2018
@sandy081
Copy link
Member

There is no such API but at the end I might also do internally. So, I see it as util method. I do not see how can we make it efficient other than checking a setting is modified for each folder or not. But internally everything comes from cache so getting a setting per resource is not costly.

@roblourens roblourens added this to the September 2018 milestone Aug 29, 2018
@roblourens
Copy link
Member

Ok, I can do it from the frontend and measure whether it affects perf. I can also do it lazily when the row is rendered.

@vscodebot vscodebot bot removed the insiders label Oct 23, 2018
@roblourens roblourens modified the milestones: November 2018, On Deck Nov 30, 2018
@rzhao271 rzhao271 added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Nov 6, 2020
@rzhao271 rzhao271 assigned rzhao271 and unassigned roblourens Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues
Projects
None yet
Development

No branches or pull requests

4 participants