Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New dropdown control should not show enumDescription preview for files.encoding #57434

Closed
roblourens opened this issue Aug 28, 2018 · 3 comments
Closed

New dropdown control should not show enumDescription preview for files.encoding #57434

roblourens opened this issue Aug 28, 2018 · 3 comments
Assignees
@roblourens
Labels
settings-editor VS Code settings editor issues

Comments

@roblourens
Copy link
Member

image
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Aug 28, 2018
@roblourens roblourens added this to the August 2018 milestone Aug 28, 2018
@roblourens roblourens self-assigned this Aug 28, 2018
@cleidigh
Copy link
Contributor

cleidigh commented Aug 28, 2018 •
edited
Loading

@roblourens
I think this is a the same thing I just posted #57447 having to do with problematic margin calculations with the new added descriptions. Sound correct?

Update:
just did more looking, it's definitely the margin calculations and scrolling calculations. I can go to this tonight and tomorrow.

@roblourens
Copy link
Member Author

I also plan to not show the extra preview window for files.encoding specifically, since I inline the enumDescriptions for that setting. I'll use this issue for that, and the layout issue can be fixed in the one you posted.

@roblourens roblourens changed the title New dropdown control is wrong for files.encoding New dropdown control should not show enumDescription preview for files.encoding Aug 28, 2018
@roblourens roblourens removed the bug Issue identified by VS Code Team member as probable bug label Aug 30, 2018
@roblourens roblourens removed this from the August 2018 milestone Aug 30, 2018
@roblourens
Copy link
Member Author

roblourens commented Aug 30, 2018 •
edited
Loading

files.encoding inlined enumDescriptions have been fixed.

@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
settings-editor VS Code settings editor issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @cleidigh