Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve settings editor dropdown layout #57662

Closed
roblourens opened this issue Aug 31, 2018 · 8 comments
Closed

Improve settings editor dropdown layout #57662

roblourens opened this issue Aug 31, 2018 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug dropdown DropDown (SelectBox widget) native and custom issues settings-editor VS Code settings editor issues verified Verification succeeded

Comments

@roblourens
Copy link
Member

Fork of #57447

The dropdown with details in the settings editor needs to account for the size of the details view when sizing and positioning itself, and when it needs to layout in an upwards direction, should (probably) have the details on top.

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Aug 31, 2018
@roblourens roblourens added this to the September 2018 milestone Aug 31, 2018
@cleidigh
Copy link
Contributor

@roblourens
finally back online, FYI my normal schedule ranges from around two to usually around eleven or later. bit of an odd schedule, just so you know. pretty much working on VSC each day.

Is this the first thing you'd like me to work on for September? I assume no commits during endgame other than the critical bugs?

@roblourens
Copy link
Member Author

We've created the release branch for 1.27 now, so commits to master are ok and will go into the September release.

@cleidigh
Copy link
Contributor

good to know I was wondering if that's what you do.
if there's any issues for August you'd like me to work on this weekend I'm good with that, otherwise I'll start on this.

@roblourens
Copy link
Member Author

I think this is the best thing to work on right now

@cleidigh
Copy link
Contributor

cleidigh commented Sep 4, 2018

If this looks good to you, I will clean and merge.

2018-09-03-23-35-17

2018-09-03-23-36-30

@roblourens
Copy link
Member Author

I think that looks great! 😁

@cleidigh
Copy link
Contributor

cleidigh commented Sep 5, 2018

yeah, until it doesn't... ran into a very odd list focus issue, seems there several ways where the list gets focus as opposed to a list item. Result is a focus ring on the whole list. I got the detailed descriptions done but still working this. Just so you didn't think I disappeared... Once I bang my head some more I'll post something.

@cleidigh
Copy link
Contributor

cleidigh commented Sep 6, 2018

Fixed: #58114

@cleidigh cleidigh added the dropdown DropDown (SelectBox widget) native and custom issues label Sep 6, 2018
@mjbvz mjbvz added the verified Verification succeeded label Sep 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug dropdown DropDown (SelectBox widget) native and custom issues settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants