Reinstallation of Code Alpha left it in a bad state

[joaomoreno]

Fixing #5463

I had Code Alpha installed in CentOS (red hat). Today, I downloaded the latest RPM, installed it and now I can't launch Code nor reinstall it.

It doesn't seem to be installed at all. It is also gone from the Applications menu, where it used to be before installing it today.

Can't even reinstall it:

[joaomoreno]

I could fix it by running sudo rpm -ev code-alpha and reinstalling the rpm package.

[Tyriar]

I think I've experienced this where the installer didn't work, it seemed like the installer's issue to me. It happened to me pretty consistently whenever I tried to install a second thing. Fresh restart and using it always seemed to work.

[astitcher]

This issue exists with the 1.2 released rpm too.

The cause is a misunderstanding about the order of running the scriptlets:

If you are upgrading the postuninstall scriptlet runs after the upgrade to uninstall anything left over in the old installation. In this case it is removing the /usr/bin/code (or code-alpha) link to /usr/share/code/bin/code just after it was created.

The postuninstall scriptlet needs to check whether an upgrade is being run and in that case just not do the remove.

I think the section should look like:

%postun
f [ $1 = 0 ]; then
  rm -f /usr/bin/code
fi

Also note that you shouldn't need sudo for any part of the rpm scripts as installing a package runs as root.

[Tyriar]

Should be fixed via PR from @astitcher