New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provideDebugAdapterTracker API feedback #59420

Closed

roblourens opened this issue Sep 26, 2018 · 1 comment

Assignees

Labels

api debug

Milestone

Member

roblourens commented Sep 26, 2018 •

edited

Loading

What's the difference between debugAdapterExit and stopDebugAdapter? I might expect that stopDebugAdapter would only come first when the stop button is clicked in vscode, but I always see stopDebugAdapter before debugAdapterExit.
Interfaces in extension API don't start with I
"Tracker" as a name is ok, some other possibilities are "DebugAdapterListener", "DebugAdapterSpy", "DebugAdapterTap", "DebugAdapterObserver"

roblourens assigned weinand

weinand added debug api labels

weinand added this to the October 2018 milestone

weinand closed this as completed in

c11c416

Contributor

weinand commented Oct 29, 2018

Thanks for the feedback!

VS Code calls stopDebugAdapter to stop the adapter whereas debugAdapterExit is sent by the DA when it exits.
I've renamed IDebugAdapterTracker to DebugAdapterTracker
I'll go with DebugAdapterTracker because "Listener" and "Observer" are misleading and "Spy" and "Tap" sound too scary.

vscodebot bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.