Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PCRE2 regex searches #60553

Closed
dwelle opened this issue Oct 10, 2018 · 1 comment
Closed

Support PCRE2 regex searches #60553

dwelle opened this issue Oct 10, 2018 · 1 comment
Assignees
@roblourens
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@dwelle
Copy link

dwelle commented Oct 10, 2018

Since rigrep supports opt-in to PCRE2 since August, can VSCode support it, also?

If perf is a concern we could opt-in to PCRE2 (via --pcre2 flag) only if the user uses PCRE2 syntax (such as lookbehind etc.).

Related: #50872
@vscodebot vscodebot bot added the search Search widget and operation issues label Oct 10, 2018
@roblourens
Copy link
Member

#60218

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 10, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @dwelle