Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick open can have duplicate entries with different path casing #6152

Closed
isidorn opened this issue May 6, 2016 · 7 comments
Closed

Quick open can have duplicate entries with different path casing #6152

isidorn opened this issue May 6, 2016 · 7 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s)
Milestone

Comments

@isidorn
Copy link
Contributor

isidorn commented May 6, 2016

I am getting duplicate debugViews.ts in recently opened. Both point to the same file, however they seem to have a different editors associated with them - eg selections are different.
Not sure how I got in this state, but I this is the first time I get duplicate entires. So my suspicion is that at a point of time the workbench created an additional editor for a file that was already open

screen shot 2016-05-06 at 09 29 50

@bpasero
Copy link
Member

bpasero commented May 6, 2016

@isidorn could be the same file with different casing because you sometimes seem to vary with your workspace path.

@bpasero
Copy link
Member

bpasero commented May 6, 2016

Just Cmd+K W the one file to get rid and File -> Open Recent -> Clear Items to get rid of all your duplicate workspace paths with different casing.

@bpasero bpasero changed the title Duplicate results in quick open Quick open can have duplicate entries with different path casing May 6, 2016
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label May 6, 2016
@bpasero bpasero added this to the Backlog milestone May 6, 2016
@bpasero bpasero modified the milestones: July 2016, Backlog, June 2016 Jul 2, 2016
@bpasero
Copy link
Member

bpasero commented Jul 6, 2016

With the update to Electron 1.2.6, fs.realPath now returns the right casing so this issue should not happen anymore.

@bpasero bpasero closed this as completed Jul 6, 2016
@isidorn
Copy link
Contributor Author

isidorn commented Jul 6, 2016

Hoooooray for fs.realPath

@bpasero bpasero reopened this Jul 8, 2016
@bpasero bpasero modified the milestones: August 2016, July 2016, Backlog Jul 8, 2016
@bpasero bpasero added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Jul 9, 2016
@bpasero bpasero removed the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Aug 31, 2016
@bpasero bpasero modified the milestones: September 2016, Backlog Sep 16, 2016
@bpasero
Copy link
Member

bpasero commented Sep 19, 2016

This landed.

@bpasero bpasero closed this as completed Sep 19, 2016
@bpasero bpasero reopened this Sep 22, 2016
@bpasero bpasero modified the milestones: Backlog, September 2016 Sep 22, 2016
@bpasero
Copy link
Member

bpasero commented Sep 22, 2016

Reopening because it looks like node.js 6.4.0 will revert the nice fs.realpath to go back to the previous JS implementation and behaviour.

@bpasero
Copy link
Member

bpasero commented Sep 22, 2016

Merging into #12448

@bpasero bpasero closed this as completed Sep 22, 2016
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 22, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants