Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring back window.smoothScrollingWorkaround #62644

Closed
isidorn opened this issue Nov 6, 2018 · 2 comments
Closed

Bring back window.smoothScrollingWorkaround #62644

isidorn opened this issue Nov 6, 2018 · 2 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded windows VS Code on Windows issues
Milestone
October 2018

Comments

@isidorn
Copy link
Contributor

isidorn commented Nov 6, 2018

Refs: #13612

We have removed window.smoothScrollingWorkaround since the new windows update has the fix for this issue.
However we should give more time for users to update to the new windows and keep this setting for one more milestone.

Commit that needs reverting d4dbfa3
@isidorn isidorn added the candidate Issue identified as probable candidate for fixing in the next release label Nov 6, 2018
@isidorn isidorn added this to the October 2018 milestone Nov 6, 2018
@isidorn isidorn self-assigned this Nov 6, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug windows VS Code on Windows issues labels Nov 6, 2018
@joaomoreno
Copy link
Member

cc @bpasero

@isidorn isidorn mentioned this issue Nov 6, 2018
Merged
@isidorn
Copy link
Contributor Author

isidorn commented Nov 6, 2018

Fixed via #62648

@isidorn isidorn closed this as completed Nov 6, 2018
@mjbvz mjbvz added the verified Verification succeeded label Nov 9, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
October 2018
Development

No branches or pull requests
3 participants
@joaomoreno @isidorn @mjbvz